Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better DisplayNames for DataSource tests #713

Closed
Tracked by #910
AbhitejJohn opened this issue May 6, 2020 · 2 comments
Closed
Tracked by #910

Better DisplayNames for DataSource tests #713

AbhitejJohn opened this issue May 6, 2020 · 2 comments

Comments

@AbhitejJohn
Copy link
Contributor

AbhitejJohn commented May 6, 2020

Description

The test result from a test adorned by a DataSourceAttribute today has a display name as follows:

TestMethodName (DataRow0)
TestMethodName (DataRow1)
.
.
.
TestMethodName (DataRown)

The only way one can know what values were passed in is to open the data source (excel/xml etc) and get a mapping. It'd be great if there was a way to configure this or even add a default with the values being used.

Steps to reproduce

Any testmethod adorned with a DataSource should exhibit this behavior.

AB#1408169

@nohwnd nohwnd assigned nohwnd and Haplois and unassigned nohwnd Jun 29, 2021
@nohwnd nohwnd added Triaged Help-Wanted The issue is up-for-grabs, and can be claimed by commenting and removed Needs: Triage 🔍 labels Jun 29, 2021
@Evangelink Evangelink added enhancement Breaking ‼️ and removed Help-Wanted The issue is up-for-grabs, and can be claimed by commenting sprint triaged labels Nov 30, 2022
@Evangelink
Copy link
Member

When implementing this change, we need to check for the test ID generation strategy as the DisplayName strategy uses the display name as part of the ID generation. This means that updating DisplayName will be considered as breaking change, causing ID instability.

This is however fine for the other strategies.

@Evangelink
Copy link
Member

I will close as won't fix because it's not clear if we will work toward supporting this in netcore one day.

@Evangelink Evangelink closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants