Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly identified need for closing brace #267

Open
russjudge opened this issue Nov 28, 2018 · 2 comments
Open

Incorrectly identified need for closing brace #267

russjudge opened this issue Nov 28, 2018 · 2 comments

Comments

@russjudge
Copy link

Attached below is the code that was identified as needing a closing brace. The plug-in marked the end of the file as the point needing the brace

index.txt

@TysonAndre
Copy link
Contributor

TysonAndre commented Nov 28, 2018

This has a parse error in php 7.0 and 7.3

Marking the syntax error to be the end of the file seems like the reasonable behavior (this typically emits errors where the MissingToken is). What do you expect the behavior to be?

It might be user friendly to have additional information about the start as well, if that's what you meant.

php -l index.txt

Parse error: syntax error, unexpected end of file in index.txt on line 67
Errors parsing index.txt

@sunverwerth
Copy link
Contributor

There is a short PHP Tag at the closing UL. I don't think tolerant PHP parser recognizes this as PHP code. Short tags are deprecated anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants