Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor trainers #1393

Closed
adamjstewart opened this issue Jun 3, 2023 · 0 comments · Fixed by #1541
Closed

Refactor trainers #1393

adamjstewart opened this issue Jun 3, 2023 · 0 comments · Fixed by #1541
Assignees
@adamjstewart
Labels
trainers PyTorch Lightning trainers
Milestone
0.5.0

Comments

@adamjstewart
Copy link
Collaborator

adamjstewart commented Jun 3, 2023 •
edited
Loading

Summary

Opening this issue so I don't forget to do this.

We added new MoCo and SimCLR trainers with a new design. We should do the same for our existing Trainers.

Rationale

Kwargs are evil, default values are nice, type hints are nice

Implementation

Same as MoCo and SimCLR

Alternatives

No response

Additional information

No response
@adamjstewart adamjstewart added this to the 0.5.0 milestone Jun 3, 2023
@adamjstewart adamjstewart added the trainers PyTorch Lightning trainers label Jun 3, 2023
@adamjstewart adamjstewart mentioned this issue Sep 6, 2023
Merged
5 tasks
@adamjstewart adamjstewart self-assigned this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjstewart adamjstewart

Labels
trainers PyTorch Lightning trainers
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Refactor trainers adamjstewart/torchgeo
1 participant
@adamjstewart