-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pathlib #1616
Comments
I would like to contribute to this, can this be assigned to me? |
Assigned, thanks for the help @pioneerHitesh! |
sklearn actually did the exact same thing in their latest release: scikit-learn/scikit-learn#27468 |
If this is still an issue, could I contribute to this? |
@pioneerHitesh was working on this, up to him whether or not he wants to let you take over. P.S. torchvision 0.17 was released a couple days ago. Does this add support for pathlib to their download/extract functions? This will make the conversion much easier in TorchGeo, I think that's the only thing we were waiting on. |
@adamjstewart The PR has not been made into stable release yet. Regarding taking over of the project. I am more inclined to complete the work myself although i appreciate @kvenkman interest in it. |
Sounds good, happy to help as needed @pioneerHitesh! |
Summary
We should add support for Python's pathlib module.
Rationale
Users may want to pass in a
Path
object instead of a string.Implementation
The type hints will change from
str
toUnion[str, bytes, os.PathLike]
according to PEP 519.Alternatives
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: