-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Triton shared does not build "out of the box" #91
Comments
This issue can probably be merged with #76. Since early December last year, triton refactored 3rd party plugin integrations. The triton commit that will work with what we have is All of this will get resolved once these two PRs are merged: |
Are we expecting both to be merged soon? |
@zhaoshiz The PR to support building 3rd party plugin hasn't been merged yet. But I have gone ahead and use a temporary branch as the current triton submodule to unblock the project for now. The reference CPU backend has been merged. Everything is back to green now. You can take a look at the new README for instructions on how to build. The steps might change slightly in the future depending on the direction we decide to go in the ongoing PR. Thank you! |
Fixed by #87 |
The instructions for building Triton shared in the README are wrong --
"This repo doesn't build by itself and must instead by built from within a Triton repo where it is included as a submodule. To add the shared middle-layer in your Triton build do export TRITON_CODEGEN_TRITON_SHARED=1 before invoking your build."
To build Triton shared you need to do two things --
Third party backends are commented out in triton/python/setup.py and will not be built unless lines 312-315
are uncommented.
The environment variable TRITON_CODEGEN_TRITON_SHARED is used by get_codegen_backends() in setup.py to determine the directory name for the plugin. The environment variable uses an underscore, "triton_shared", while the git repo uses a dash, "triton-shared". The directory must be renamed to "triton_shared" or it will not be built.
The text was updated successfully, but these errors were encountered: