Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

react-a11y-accessible-headings is missing from recommended_ruleset.js #696

Closed
JoshuaKGoldberg opened this issue Dec 27, 2018 · 2 comments · Fixed by #699
Closed

react-a11y-accessible-headings is missing from recommended_ruleset.js #696

JoshuaKGoldberg opened this issue Dec 27, 2018 · 2 comments · Fixed by #699
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs Type: Bug
Milestone
6.1.0-beta

Comments

@JoshuaKGoldberg
Copy link

Bug Report

  • tslint-microsoft-contrib version: Latest on master

Spinning off of #686 - react-a11y-accessible-headings isn't mentioned in recommended_ruleset.js. Running npm run test re-adds it back in.
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Status: Accepting PRs Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. labels Dec 27, 2018
@IllusionMH
Copy link
Contributor

I have an impression (may be wrong) that contributors are not sure if they should add/commit changes to automatically generated files (specifically recommended_ruleset.js and tslint-warnings.csv).

It may worth to add information to CONTRIBUTING.md that changes in these files related to new rules should be also commited. And during review check if changes are present and ask to add for example recommended: 'false, // to strict' to rule metadata.

What do you think?

@JoshuaKGoldberg
Copy link
Author

Agreed. I think it'd be good to have a comment on top of recommended_ruleset.js linking to those docs too.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 27, 2018
Merged
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 27, 2018
Closed
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Domain: Tooling Repository tasks around improving source tooling. Status: Accepting PRs Type: Bug
Projects
None yet
Milestone
6.1.0-beta
Development

Successfully merging a pull request may close this issue.

Added missing react-a11y-accessible-headings to recommended ruleset
2 participants
@IllusionMH @JoshuaKGoldberg