Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark suggestions #32

Open
4 of 23 tasks
jakebailey opened this issue Feb 2, 2024 · 3 comments
Open
4 of 23 tasks

Benchmark suggestions #32

jakebailey opened this issue Feb 2, 2024 · 3 comments

Comments

@jakebailey
Copy link
Member

jakebailey commented Feb 2, 2024

General criteria

A benchmark:

  • Must be compile with a simple npm|yarn|pnpm install and tsc -p or tsc -b. No funky build systems, no random external artifacts if possible.
    • Compiling with -p is preferred, to prevent fail-fast behavior.
    • Emitting with tsc is even better. Especially declaration emit
  • Should compile in less than 60 seconds or so. If you have a benchmark and it takes like 5 minutes to build, that deserves a bug!

Potential candidates

Pulling this list out of microsoft/TypeScript#44033

Being in this list does not guarantee that actually want to add the benchmarks, or that there aren't other benchmarks we could add.

Our benchmarking system uses tuned physical machines for accurate measurement, so benchmarking time is limited. More capacity is on the way, and removing our old legacy internal benchmarks will free up more time.

@jakebailey
Copy link
Member Author

This code apparently takes a super long time to check (with the PR in place): https://github.com/reduxjs/reselect/blob/ce9e875d2437ad1dbb701e0d8945a4fa3665f709/type-tests/deepNesting.test-d.ts#L49

And may represent an interesting benchmark.

@RyanCavanaugh
Copy link
Member

@jakebailey
Copy link
Member Author

@Jolg42 Do you have any links to what kind of prima benchmark you were looking to add in microsoft/TypeScript#44033 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants