-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark suggestions #32
Comments
This code apparently takes a super long time to check (with the PR in place): https://github.com/reduxjs/reselect/blob/ce9e875d2437ad1dbb701e0d8945a4fa3665f709/type-tests/deepNesting.test-d.ts#L49 And may represent an interesting benchmark. |
@Jolg42 Do you have any links to what kind of prima benchmark you were looking to add in microsoft/TypeScript#44033 (comment)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
General criteria
A benchmark:
npm|yarn|pnpm install
andtsc -p
ortsc -b
. No funky build systems, no random external artifacts if possible.-p
is preferred, to prevent fail-fast behavior.Potential candidates
Pulling this list out of microsoft/TypeScript#44033
https://github.com/ChromeDevTools/devtools-frontendthis build is way too custom; tsconfigs do not actually buildBeing in this list does not guarantee that actually want to add the benchmarks, or that there aren't other benchmarks we could add.
Our benchmarking system uses tuned physical machines for accurate measurement, so benchmarking time is limited. More capacity is on the way, and removing our old legacy internal benchmarks will free up more time.
The text was updated successfully, but these errors were encountered: