Fix SourceFileAffecting for options used in binder

Author: jakebailey

internal/core/compileroptions.go

@@ -264,22 +264,30 @@ func (options *CompilerOptions) HasJsonModuleEmitEnabled() bool {
 // changed require a new SourceFile be created.
 type SourceFileAffectingCompilerOptions struct {
 	// !!! generate this
-	Target          ScriptTarget
-	Jsx             JsxEmit
-	JsxImportSource string
-	ImportHelpers   Tristate
-	AlwaysStrict    Tristate
-	ModuleDetection ModuleDetectionKind
+	Target               ScriptTarget
+	Jsx                  JsxEmit
+	JsxImportSource      string
+	ImportHelpers        Tristate
+	AlwaysStrict         Tristate
+	ModuleDetection      ModuleDetectionKind
+	AllowUnreachableCode Tristate
+	AllowUnusedLabels    Tristate
+	PreserveConstEnums   Tristate
+	IsolatedModules      Tristate
 }
 
 func (options *CompilerOptions) SourceFileAffecting() SourceFileAffectingCompilerOptions {
 	return SourceFileAffectingCompilerOptions{
-		Target:          options.Target,
-		Jsx:             options.Jsx,
-		JsxImportSource: options.JsxImportSource,
-		ImportHelpers:   options.ImportHelpers,
-		AlwaysStrict:    options.AlwaysStrict,
-		ModuleDetection: options.ModuleDetection,
+		Target:               options.Target,
+		Jsx:                  options.Jsx,
+		JsxImportSource:      options.JsxImportSource,
+		ImportHelpers:        options.ImportHelpers,
+		AlwaysStrict:         options.AlwaysStrict,
+		ModuleDetection:      options.ModuleDetection,
+		AllowUnreachableCode: options.AllowUnreachableCode,
+		AllowUnusedLabels:    options.AllowUnusedLabels,
+		PreserveConstEnums:   options.PreserveConstEnums,
+		IsolatedModules:      options.IsolatedModules,
 	}
 }
 

testdata/baselines/reference/submodule/compiler/unreachableDeclarations(preserveconstenums=false).errors.txt

@@ -4,8 +4,6 @@ unreachableDeclarations.ts(14,5): error TS7027: Unreachable code detected.
 unreachableDeclarations.ts(21,17): error TS2450: Enum 'EnumA' used before its declaration.
 unreachableDeclarations.ts(29,5): error TS7027: Unreachable code detected.
 unreachableDeclarations.ts(29,5): error TS7027: Unreachable code detected.
-unreachableDeclarations.ts(43,5): error TS7027: Unreachable code detected.
-unreachableDeclarations.ts(43,5): error TS7027: Unreachable code detected.
 unreachableDeclarations.ts(49,17): error TS2449: Class 'ClassA' used before its declaration.
 unreachableDeclarations.ts(57,5): error TS7027: Unreachable code detected.
 unreachableDeclarations.ts(57,5): error TS7027: Unreachable code detected.
@@ -18,7 +16,7 @@ unreachableDeclarations.ts(78,2): error TS7027: Unreachable code detected.
 unreachableDeclarations.ts(84,2): error TS1235: A namespace declaration is only allowed at the top level of a namespace or module.
 
 
-==== unreachableDeclarations.ts (18 errors) ====
+==== unreachableDeclarations.ts (16 errors) ====
     function func1() {
         aFunc();
 
@@ -37,12 +35,10 @@ unreachableDeclarations.ts(84,2): error TS1235: A namespace declaration is only
 
         enum EnumA { Value }
         ~~~~~~~~~~~~~~~~~~~~
-        ~~~~~~~~~~~~~~~~~~~~
-        const enum EnumB { Value }
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS7027: Unreachable code detected.
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+        ~~~~~~~~~~~~~~~~~~~~
 !!! error TS7027: Unreachable code detected.
+        const enum EnumB { Value }
     }
 
     function func2() {
@@ -78,10 +74,6 @@ unreachableDeclarations.ts(84,2): error TS1235: A namespace declaration is only
         }
 
         const enum EnumB { Value }
-        ~~~~~~~~~~~~~~~~~~~~~~~~~~
-!!! error TS7027: Unreachable code detected.
-        ~~~~~~~~~~~~~~~~~~~~~~~~~~
-!!! error TS7027: Unreachable code detected.
     }
 
     function func4() {

testdata/baselines/reference/submodule/compiler/unreachableDeclarations(preserveconstenums=false).errors.txt.diff

@@ -7,8 +7,6 @@
  unreachableDeclarations.ts(21,17): error TS2450: Enum 'EnumA' used before its declaration.
  unreachableDeclarations.ts(29,5): error TS7027: Unreachable code detected.
 +unreachableDeclarations.ts(29,5): error TS7027: Unreachable code detected.
-+unreachableDeclarations.ts(43,5): error TS7027: Unreachable code detected.
-+unreachableDeclarations.ts(43,5): error TS7027: Unreachable code detected.
  unreachableDeclarations.ts(49,17): error TS2449: Class 'ClassA' used before its declaration.
  unreachableDeclarations.ts(57,5): error TS7027: Unreachable code detected.
 +unreachableDeclarations.ts(57,5): error TS7027: Unreachable code detected.
@@ -22,25 +20,20 @@
 
 
 -==== unreachableDeclarations.ts (12 errors) ====
-+==== unreachableDeclarations.ts (18 errors) ====
++==== unreachableDeclarations.ts (16 errors) ====
      function func1() {
          aFunc();
 
-@@= skipped -30, +36 lines =@@
-     
+@@= skipped -31, +35 lines =@@
          enum EnumA { Value }
          ~~~~~~~~~~~~~~~~~~~~
--!!! error TS7027: Unreachable code detected.
+ !!! error TS7027: Unreachable code detected.
 +        ~~~~~~~~~~~~~~~~~~~~
-         const enum EnumB { Value }
-+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-+!!! error TS7027: Unreachable code detected.
-+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 +!!! error TS7027: Unreachable code detected.
+         const enum EnumB { Value }
      }
 
-     function func2() {
-@@= skipped -21, +25 lines =@@
+@@= skipped -20, +22 lines =@@
          enum EnumA { Value }
          ~~~~~~~~~~~~~~~~~~~~
  !!! error TS7027: Unreachable code detected.
@@ -49,18 +42,7 @@
      }
 
      function func3() {
-@@= skipped -14, +16 lines =@@
-         }
-     
-         const enum EnumB { Value }
-+        ~~~~~~~~~~~~~~~~~~~~~~~~~~
-+!!! error TS7027: Unreachable code detected.
-+        ~~~~~~~~~~~~~~~~~~~~~~~~~~
-+!!! error TS7027: Unreachable code detected.
-     }
-     
-     function func4() {
-@@= skipped -19, +23 lines =@@
+@@= skipped -33, +35 lines =@@
          class ClassA { static Value = 1234; }
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  !!! error TS7027: Unreachable code detected.