-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with React 19 #31
Comments
#32 should fix the throwing in React 19. However, there are still two tests that fail due to effect ordring differences. Will need to look further there |
Seems that Next.js with their canary versions is also affected, microsoft/fluentui#31930. |
Any Updates? |
@elliot-huffman nope, it's not a high prio item now. |
how can we fix it temporarily even for sake of build? |
@ibrahim-bayer there is no way to fix it. It's not fixable by design. I made a refactor #33174 in Fluent to avoid usage of this package, but it breaks in certain scenarios. |
This library makes use of
React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentOwner
, which is removed in React 19.Therefore, when trying to use it with React 19, you get "TypeError: Cannot read properties of undefined (reading 'ReactCurrentOwner')".
Reproduction: https://codesandbox.io/p/sandbox/fluentui-react-components-with-react-19-g4g5pw?file=%2Fsrc%2FApp.tsx
The error happens here:
use-disposable/src/useIsStrictMode.ts
Lines 6 to 9 in 3e3d4a3
The text was updated successfully, but these errors were encountered: