Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check format of vcpkg.json file in x-add-version #16880

Closed
autoantwort opened this issue Mar 25, 2021 · 0 comments · Fixed by microsoft/vcpkg-tool#43
Closed

Check format of vcpkg.json file in x-add-version #16880

autoantwort opened this issue Mar 25, 2021 · 0 comments · Fixed by microsoft/vcpkg-tool#43
Assignees
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:versioning This PR or Issue pertains to the versioning feature

Comments

@autoantwort
Copy link
Contributor

The x-add-version command already checks if there are vcpkg.json file changes that are not committed. I should also check if the vcpkg.json file is well formatted.


Is your feature request related to a problem? Please describe.
I use VS Code to edit the vcpkg.json files, but when I save a plugin formats the json file, but in an incompatible format to vcpkg (4 spaces indention). Often I forgot about that, commit the changes, run vcpkg x-add-version ..., commit and push the changes. After a few minutes I see the failure in the pipeline.

Proposed solution
Check if the vcpkg.json file is whell formatted when running vcpkg x-add-version ...

@PhoebeHui PhoebeHui added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:versioning This PR or Issue pertains to the versioning feature labels Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:versioning This PR or Issue pertains to the versioning feature
Projects
None yet
4 participants