-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icu:x64-windows-static] build failure #18086
Comments
Please provide the following failure logs: |
Please ensure you've installed the English Language Package and fix Visual Studio using Visual Studio Installer. |
|
I have a similar problem here, what could be related to it. Here are the log files. |
Can you please add option Thanks. |
|
@michael-schantin Can you please make sure your vcpkg is latest? |
|
My is: |
@ras0219 @ras0219-msft can you please take a look? Thanks. |
Also, please provide config.log in buildtrees/icu/x64-windows-static. Thanks. |
|
@johnnyschneider C:\dev\vcpkg\buildtrees\icu\x64-windows-static-dbg\config.log. |
config.log |
@johnnyschneider Please also provide C:\dev\vcpkg\buildtrees\icu\config.log-x64-windows-static-dbg.log and C:\dev\vcpkg\buildtrees\icu\config-x64-windows-static-dbg-out.log. |
All configurations seem to differ only in paths. I think this issue is related to Visual Studio. |
I'll take a look at this tomorrow; I need access to a windows machine and I'm not at home right now. |
cc @autoantwort, any thoughts? |
@PhoebeHui There doesn't seem to be any instance of LIB.exe in any of my vcpkg builds i.e. 2021.05.12 (which has an error building) and the other on 2021.04.30 (which builds successfully). I just have the following directories in the .\vcpkg\downloads\tools directory
|
It is a leftover from the previous version of the portfile. I removed it in #19620 |
Hi guys, can you please test PR #19620? |
@johnnyschneider @zapcity, could you help test PR #19620 and see if it works for you? |
@PhoebeHui I tried testing #19620 but seem to get the same errors (if I'm testing this right): Commands used:
Output:
E:\dev\projects\projectx\vcpkg\buildtrees\icu\build-x64-windows-static-dbg-err.log
Local repo: |
Same issue. I am on Windows 10 Enterprise, 64-bit, and have pulled and installed the latest
Ironically, I even downloaded icu4c-69_1-Win64-MSVC2019.zip from GitHub, placed it in |
@adamgranthendry Sorry, but as far I can see this is complete different issue. Please open a new issue for that. For the rest: Can you test my new PR #19672? |
@autoantwort Ah I see. Yes, I will open a new issue. Thank you. |
@PhoebeHui @JackBoosY @autoantwort I've been digging deeper into what's possibly going wrong. Here I'm only using the master branch to try and compile icu:x64-windows-static via:
It seems that if I compile within any path whose top level directory is named "dev", then it doesn't compile e.g.
However it works if I use anything else e.g.
Looking at the logs of the other people in this thread who can't compile icu i.e. @johnnyschneider and @michael-schantin, they too are compiling within a path whose top level directory is "dev" i.e. C:\dev\vcpkg, so there is something going on here. Quickly checking the code, there seems to be a lot of references to bash's "/dev/null", which might be interfering somehow (as it uses keyword 'dev') ? I'll continue looking into this when I have time, but I am no expert. |
@zapcity, thanks for taking a deeper investigation! I can repro this issue locally. |
@zapcity, I have submitted a PR to fix this, it works for me, could you help double confirm if it works for you? |
@PhoebeHui , thanks. I have checked #19726 and it is working for me! 😃 |
Host Environment
To Reproduce
Steps to reproduce the behavior:
./vcpkg install icu:x64-windows-static
Failure logs
The text was updated successfully, but these errors were encountered: