Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove absolute paths from installed files #20469

Closed
34 of 38 tasks
autoantwort opened this issue Oct 1, 2021 · 6 comments
Closed
34 of 38 tasks

Remove absolute paths from installed files #20469

autoantwort opened this issue Oct 1, 2021 · 6 comments
Assignees
@PhoebeHui @MonicaLiu0311
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@autoantwort
Copy link
Contributor

autoantwort commented Oct 1, 2021 •
edited
Loading

While developing microsoft/vcpkg-tool#172 it was discovered that many ports (160) have absolute paths the the packages dir in their result. These paths must be updated to relative paths, for example by vcpkg_fixup_pkgconfig.

List of ports
  • ace
  • bcg729
  • cgns
  • cminpack
  • dcmtk
  • fontconfig
  • ftgl
  • gdcm
  • gdk-pixbuf
  • glib
  • glibmm
  • graphite2
  • hdf5
  • hpx
  • ignition-msgs1
  • ismrmrd
  • lager
  • libftdi1
  • libgit2
  • libheif
  • libpmemobj-cpp
  • libpng
  • libwebsockets
  • minitrace
  • mongo-c-driver
  • mongo-cxx-driver
  • netcdf-c
  • ompl
  • plplot
  • protopuf
  • qpid-proton
  • sdformat6
  • shapelib
  • simage
  • symengine
  • woff2
  • xtensor-blas
  • xtensor-io
List of wrong files 
ace:x64-osx: x64-osx/share/ace/ace-devel.sh
ace:x64-osx: x64-osx/share/ace/bin/MakeProjectCreator/config/MPC.cfg
ace:x64-osx: x64-osx/share/ace/include/makeinclude/wrapper_macros.GNU
bcg729:x64-osx: x64-osx/share/Bcg729/cmake/Bcg729Config.cmake
cgns:x64-osx: x64-osx/share/cgns/cgnsBuild.defs
dcmtk:x64-osx: x64-osx/include/dcmtk/config/osconfig.h
fontconfig:x64-osx: x64-osx/etc/fonts/conf.d/README
fontconfig:x64-osx: x64-osx/etc/fonts/fonts.conf
ftgl:x64-osx: x64-osx/share/ftgl/FTGL/FTGLConfig.cmake
gdcm:x64-osx: x64-osx/include/gdcmConfigure.h
gdk-pixbuf:x64-osx: x64-osx/debug/gdk-pixbuf-2.0/2.10.0/loaders.cache
gdk-pixbuf:x64-osx: x64-osx/debug/gdk-pixbuf-2.0/2.10.0/loaders.cache
gdk-pixbuf:x64-osx: x64-osx/gdk-pixbuf-2.0/2.10.0/loaders.cache
gdk-pixbuf:x64-osx: x64-osx/share/thumbnailers/gdk-pixbuf-thumbnailer.thumbnailer
glib:x64-osx: x64-osx/share/gdb/auto-load/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/glib_x64-osx/lib/libglib-2.0.so.0.6600.4-gdb.py
glib:x64-osx: x64-osx/share/gdb/auto-load/Users/leanderSchulten/git_projekte/Lichtsteuerung/vcpkg/packages/glib_x64-osx/lib/libgobject-2.0.so.0.6600.4-gdb.py
glib:x64-osx: x64-osx/tools/glib/glib-gettextize
glibmm:x64-osx: x64-osx/debug/lib/glibmm-2.68/proc/gmmproc
glibmm:x64-osx: x64-osx/debug/lib/glibmm-2.68/proc/gmmproc
glibmm:x64-osx: x64-osx/lib/glibmm-2.68/proc/gmmproc
graphite2:x64-osx: x64-osx/debug/lib/libgraphite2.la
graphite2:x64-osx: x64-osx/debug/lib/libgraphite2.la
graphite2:x64-osx: x64-osx/lib/libgraphite2.la
hdf5:x64-osx: x64-osx/debug/lib/libhdf5.settings
hdf5:x64-osx: x64-osx/debug/lib/libhdf5.settings
hdf5:x64-osx: x64-osx/lib/libhdf5.settings
hpx:x64-osx: x64-osx/bin/hpxcxx
hpx:x64-osx: x64-osx/debug/bin/hpxcxx
hpx:x64-osx: x64-osx/debug/bin/hpxcxx
ignition-msgs1:x64-osx: x64-osx/share/ignition/msgs1.yaml
ismrmrd:x64-osx: x64-osx/share/ismrmrd/cmake/ISMRMRDConfig.cmake
lager:x64-osx: x64-osx/include/lager/resources_path.hpp
lager:x64-osx: x64-osx/include/lager/resources_path.hpp.in
libftdi1:x64-osx: x64-osx/debug/lib/pkgconfig/libftdi1.pc
libftdi1:x64-osx: x64-osx/debug/lib/pkgconfig/libftdi1.pc
libftdi1:x64-osx: x64-osx/debug/lib/pkgconfig/libftdipp1.pc
libftdi1:x64-osx: x64-osx/debug/lib/pkgconfig/libftdipp1.pc
libftdi1:x64-osx: x64-osx/lib/pkgconfig/libftdi1.pc
libftdi1:x64-osx: x64-osx/lib/pkgconfig/libftdipp1.pc
libgit2:x64-osx: x64-osx/debug/lib/pkgconfig/libgit2.pc
libgit2:x64-osx: x64-osx/debug/lib/pkgconfig/libgit2.pc
libgit2:x64-osx: x64-osx/lib/pkgconfig/libgit2.pc
libheif:x64-osx: x64-osx/debug/lib/pkgconfig/libheif.pc
libheif:x64-osx: x64-osx/debug/lib/pkgconfig/libheif.pc
libheif:x64-osx: x64-osx/lib/pkgconfig/libheif.pc
libpmemobj-cpp:x64-osx: x64-osx/lib/pkgconfig/libpmemobj++.pc
libpng:x64-osx: x64-osx/debug/tools/libpng/libpng-config
libpng:x64-osx: x64-osx/debug/tools/libpng/libpng-config
libpng:x64-osx: x64-osx/debug/tools/libpng/libpng16-config
libpng:x64-osx: x64-osx/debug/tools/libpng/libpng16-config
libpng:x64-osx: x64-osx/tools/libpng/libpng-config
libpng:x64-osx: x64-osx/tools/libpng/libpng16-config
libwebsockets:x64-osx: x64-osx/include/lws_config.h
minitrace:x64-osx: x64-osx/share/minitrace/minitraceConfig-release.cmake
minitrace:x64-osx: x64-osx/share/minitrace/minitraceConfig.cmake
mongo-c-driver:x64-osx: x64-osx/share/mongo-c-driver/uninstall.sh
mongo-cxx-driver:x64-osx: x64-osx/debug/lib/pkgconfig/libbsoncxx-static.pc
mongo-cxx-driver:x64-osx: x64-osx/debug/lib/pkgconfig/libbsoncxx-static.pc
mongo-cxx-driver:x64-osx: x64-osx/debug/lib/pkgconfig/libmongocxx-static.pc
mongo-cxx-driver:x64-osx: x64-osx/debug/lib/pkgconfig/libmongocxx-static.pc
mongo-cxx-driver:x64-osx: x64-osx/lib/pkgconfig/libbsoncxx-static.pc
mongo-cxx-driver:x64-osx: x64-osx/lib/pkgconfig/libmongocxx-static.pc
mongo-cxx-driver:x64-osx: x64-osx/share/mongo-cxx-driver/uninstall.sh
netcdf-c:x64-osx: x64-osx/debug/lib/libnetcdf.settings
netcdf-c:x64-osx: x64-osx/debug/lib/libnetcdf.settings
netcdf-c:x64-osx: x64-osx/lib/libnetcdf.settings
ompl:x64-osx: x64-osx/debug/lib/pkgconfig/ompl.pc
ompl:x64-osx: x64-osx/debug/lib/pkgconfig/ompl.pc
ompl:x64-osx: x64-osx/lib/pkgconfig/ompl.pc
plplot:x64-osx: x64-osx/share/plplot/examples/cmake/modules/plplot_configure.cmake
plplot:x64-osx: x64-osx/share/plplot/examples/fortran/Makefile
plplot:x64-osx: x64-osx/share/plplot/examples/plplot-test-interactive.sh
protopuf:x64-osx: x64-osx/share/protopuf/protopufConfig.cmake
qpid-proton:x64-osx: x64-osx/include/proton/version.h
sdformat6:x64-osx: x64-osx/include/sdformat-6.2/sdf/sdf_config.h
sdformat6:x64-osx: x64-osx/share/ignition/sdformat6.yaml
shapelib:x64-osx: x64-osx/share/shp/export_shp.cmake
simage:x64-osx: x64-osx/share/Coin/conf/simage-default.cfg
symengine:x64-osx: x64-osx/include/symengine/symengine_config_cling.h
woff2:x64-osx: x64-osx/debug/lib/pkgconfig/libwoff2common.pc
woff2:x64-osx: x64-osx/debug/lib/pkgconfig/libwoff2common.pc
woff2:x64-osx: x64-osx/debug/lib/pkgconfig/libwoff2dec.pc
woff2:x64-osx: x64-osx/debug/lib/pkgconfig/libwoff2dec.pc
woff2:x64-osx: x64-osx/debug/lib/pkgconfig/libwoff2enc.pc
woff2:x64-osx: x64-osx/debug/lib/pkgconfig/libwoff2enc.pc
woff2:x64-osx: x64-osx/lib/pkgconfig/libwoff2common.pc
woff2:x64-osx: x64-osx/lib/pkgconfig/libwoff2dec.pc
woff2:x64-osx: x64-osx/lib/pkgconfig/libwoff2enc.pc
xtensor-blas:x64-osx: x64-osx/include/xtensor-blas/xblas_config_cling.hpp
xtensor-io:x64-osx: x64-osx/include/xtensor-io/xtensor_io_config.hpp
@autoantwort autoantwort changed the title Remove absolute paths from build Remove absolute paths from installed files Oct 1, 2021
@dg0yt
Copy link
Contributor

dg0yt commented Oct 2, 2021

FTR some ports probably still just remove <pkg>-config scripts instead of fixing them.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Oct 8, 2021
@JackBoosY
Copy link
Contributor

Port bug? Maybe we can fix them in vcpkg_fixup_pkgconfig thoroughly, that should be marked as tool-update.

@autoantwort
Copy link
Contributor Author

Port Bug. Yes the problem is fixed when calling vcpkg_fixup_pkgconfig in the ports. The problem is that these ports don't call vcpkg_fixup_pkgconfig

This was referenced Oct 25, 2021
Merged
Closed
@PhoebeHui
Copy link
Contributor

The PR has been merged, thanks for your contribution!

@autoantwort
Copy link
Contributor Author

@PhoebeHui Please reopen the Issue, there are still absolute paths in the installed dir. I updated the issue with the current list.

@PhoebeHui PhoebeHui reopened this Oct 29, 2021
This was referenced Oct 30, 2021
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 27, 2022
Merged
Merged
Merged
This was referenced Nov 17, 2022
Merged
Merged
This was referenced Dec 1, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@LilyWangLL LilyWangLL assigned MonicaLiu0311 and unassigned JackBoosY Dec 6, 2022
@autoantwort autoantwort mentioned this issue Dec 6, 2022
Merged
@autoantwort autoantwort mentioned this issue Dec 15, 2022
Merged
This was referenced Dec 26, 2022
Merged
Merged
This was referenced Jan 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 22, 2023
Merged
Merged
@autoantwort
Copy link
Contributor Author

After 238 Merged PRs this can be finally closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhoebeHui PhoebeHui

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dg0yt @PhoebeHui @autoantwort @JackBoosY @MonicaLiu0311