[sdl2-mixer] build failure with mpg123

[matthiakl]

Host Environment

• OS: Windows 10
• Compiler: Visual Studio 2019

To Reproduce
Steps to reproduce the behavior:
.\vcpkg.exe install sdl2-mixer[core,libflac,libvorbis,mpg123,nativemidi]:x64-windows-static

Failure logs

-- Configuring x64-windows-static
CMake Warning at installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:485 (message):
  The following variables are not used in CMakeLists.txt:

      LIBRARY_SUFFIX

  Please recheck them and remove the unnecessary options from the
  `vcpkg_cmake_configure` call.

  If these options should still be passed for whatever reason, please use the
  `MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
  ports/sdl2-mixer/portfile.cmake:42 (vcpkg_cmake_configure)
  scripts/ports.cmake:142 (include)


-- Building x64-windows-static-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
    Command failed: C:/vcpkg/downloads/tools/cmake-3.21.1-windows/cmake-3.21.1-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j3
    Working Directory: C:/vcpkg/buildtrees/sdl2-mixer/x64-windows-static-dbg
    See logs for more information:
      C:\vcpkg\buildtrees\sdl2-mixer\install-x64-windows-static-dbg-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:102 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/sdl2-mixer/portfile.cmake:51 (vcpkg_cmake_install)
  scripts/ports.cmake:142 (include)


Error: Building package sdl2-mixer:x64-windows-static failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `.\vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+sdl2-mixer
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[sdl2-mixer]+Build+error
including:
  package: sdl2-mixer[core,libflac,libvorbis,mpg123,nativemidi]:x64-windows-static -> 2.0.4#13
    vcpkg-tool version: 2021-11-24-48b94a6946b8a70abd21529218927fd478d02b6c
    vcpkg-scripts version: ed74ff32c 2021-11-30 (14 minutes ago)

[18/24] C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\cl.exe   -DMUSIC_FLAC -DMUSIC_MID_NATIVE -DMUSIC_MP3_MPG123 -DMUSIC_OGG -DMUSIC_WAV -IC:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\.\native_midi -IC:\vcpkg\installed\x64-windows-static\include\SDL2 -IC:\vcpkg\installed\x64-windows-static\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1 /showIncludes /FoCMakeFiles\SDL2_mixer.dir\music_mpg123.c.obj /FdCMakeFiles\SDL2_mixer.dir\SDL2_mixer.pdb /FS -c C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c
FAILED: CMakeFiles/SDL2_mixer.dir/music_mpg123.c.obj 
C:\PROGRA~2\MICROS~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\cl.exe   -DMUSIC_FLAC -DMUSIC_MID_NATIVE -DMUSIC_MP3_MPG123 -DMUSIC_OGG -DMUSIC_WAV -IC:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\.\native_midi -IC:\vcpkg\installed\x64-windows-static\include\SDL2 -IC:\vcpkg\installed\x64-windows-static\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /MP  /D_DEBUG /MTd /Z7 /Ob0 /Od /RTC1 /showIncludes /FoCMakeFiles\SDL2_mixer.dir\music_mpg123.c.obj /FdCMakeFiles\SDL2_mixer.dir\SDL2_mixer.pdb /FS -c C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2143: syntax error: missing ')' before '('
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2081: 'ssize_t': name in formal parameter list illegal
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2143: syntax error: missing ')' before '*'
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2091: function returns function
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2143: syntax error: missing ';' before '*'
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2059: syntax error: '*'
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(52): error C2059: syntax error: ')'
C:\vcpkg\buildtrees\sdl2-mixer\src\2.0.4-a895b09396.clean\music_mpg123.c(53): error C2365: 'mpg123_seek': redefinition; previous definition was 'function'
C:\vcpkg\installed\x64-windows-static\include\mpg123.h(985): note: see declaration of 'mpg123_seek'
...

install-x64-windows-static-dbg-out.log

Additional context
I noticed it in my Github CI, where vcpkg received an update recently:

vcpkg-tool version: 2021-11-24-48b94a6946b8a70abd21529218927fd478d02b6c
vcpkg-scripts version: 60a8f7971 2021-11-29 (25 hours ago)

[Sodacooky]

I went through the same problem like you (libsdl-org/SDL_mixer#339).
They "have" fixed it but the problem still.

[LilyWangLL]

Due to sdl2-mixer depends on old version of mpg123, it doesn't support latest version of mpg123. I have submitted issue on upstream libsdl-org/SDL_mixer#340. I will disable feature mpg123 temporarily, untill sdl2-mixer supports the latest version of mpg123.

[LilyWangLL]

The upstream issue has been fixed, I will fix this issue soon.