Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[many ports] Incorrectly excluding dynamic triplets on windows #25149

Closed
4 tasks done
Thomas1664 opened this issue Jun 8, 2022 · 0 comments · Fixed by #26953
Closed
4 tasks done

[many ports] Incorrectly excluding dynamic triplets on windows #25149

Thomas1664 opened this issue Jun 8, 2022 · 0 comments · Fixed by #26953
Assignees
@LilyWangLL
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Thomas1664
Copy link
Contributor

Thomas1664 commented Jun 8, 2022 •
edited
Loading

Some ports contain !(windows & !static) (i.e. only static builds on Windows). This is incorrect because they can still build static libraries on these triplets as they don't require strictly just dynamic builds (the correct triplet for that scenario would be x64-windows-dynamic).
The correct way of disallowing DLLs is via vcpkg_check_linkage(ONLY_STATIC_LIBRARY).

The following ports are affected:

  • hexl
  • jsonnet
  • opentelemetry-cpp
  • quantlib
@Thomas1664 Thomas1664 mentioned this issue Jun 8, 2022
Merged
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Jun 9, 2022
@Thomas1664 Thomas1664 mentioned this issue Jun 11, 2022
Merged
@Thomas1664 Thomas1664 mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[jsonnet, opentelemetry-cpp] Remove !(windows & !static) Thomas1664/vcpkg
2 participants
@Thomas1664 @LilyWangLL