Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS solutions/projects in the ports folder pollute VS targets list #31652

Closed
Trider12 opened this issue May 26, 2023 · 6 comments · Fixed by #31749
Closed

VS solutions/projects in the ports folder pollute VS targets list #31652

Trider12 opened this issue May 26, 2023 · 6 comments · Fixed by #31749
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@Trider12
Copy link
Contributor

Trider12 commented May 26, 2023

Describe the bug
When using vcpkg as a submodule, various .sln and .vcxproj files located in the vcpkg/ports/ directory pollute the targets list of Visual Studio:

image

Environment

  • OS: Windows
  • IDE: VS2022

To Reproduce
Steps to reproduce the behavior:

  1. Create a CMake project (not sure whether the same problem occurs with VS projects)
  2. Have vcpkg cloned somewhere inside the project directory

Expected behavior

  • Solution 1: remove these types of files from vcpkg
  • Solution 2: some way to tell VS to ignore the vcpkg folder

Additional context
The Show/Hide Debug Targets feature is helpful, but requires to manually select every target imported by vcpkg and is reset when VS project cache is deleted.

@Trider12
Copy link
Contributor Author

The same problem occurs in the Solution Explorer window, but there's no filtering functionality there:
image

@MonicaLiu0311 MonicaLiu0311 added the requires:more-information This Issue requires more information to solve label May 29, 2023
@MonicaLiu0311
Copy link
Contributor

To Reproduce
Steps to reproduce the behavior:

  1. Create a CMake project (not sure whether the same problem occurs with VS projects)
  2. Have vcpkg cloned somewhere inside the project directory

Are there some steps to reproduce? May I ask how you use vcpkg in cmake?

@Trider12
Copy link
Contributor Author

May I ask how you use vcpkg in cmake?

You don't even need to "use" vcpkg to observe this issue. Just have vcpkg cloned inside a CMake project folder and then open that project in VS.

@MonicaLiu0311
Copy link
Contributor

I did this, but sorry I didn't reproduce your issue. After the build, there are only original files in the ports/ directory, without .sln and .vcxproj.
image

@Trider12
Copy link
Contributor Author

After the build, there are only original files in the ports/ directory

I didn't mean the ports/ directory literally. I meant that ports inside that directory have these files. Just open the targets list like in the screenshot I provided.

@MonicaLiu0311
Copy link
Contributor

SDL1: #4492
winpcap: #5478
sdl1-mixer: #30921

Confirmed, I will follow #31685 to fix it to avoid them being detected by VS.

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support and removed requires:more-information This Issue requires more information to solve labels May 31, 2023
@Cheney-W Cheney-W added category:question This issue is a question and removed category:port-bug The issue is with a library, which is something the port should already support labels Jun 1, 2023
@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support and removed category:question This issue is a question labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants