Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvokeAsync throws ArgumentNullException after stream is disposed #33

Closed
AArnott opened this issue Apr 27, 2017 · 1 comment
Closed

InvokeAsync throws ArgumentNullException after stream is disposed #33

AArnott opened this issue Apr 27, 2017 · 1 comment
Labels
wontfix

Comments

@AArnott
Copy link
Member

AArnott commented Apr 27, 2017 •
edited
Loading

As caught in dotnet/roslyn#18563, we sometimes allow an ArgumentNullException to propagate from SemaphoreSlim->AsyncSemaphore->StreamJsonRpc.DelimitedMessageHandler->JsonRpc.InvokeCoreAsync and eventually to our caller. When our caller is Roslyn, then tend to crash VS.

@sharwell reports a NullReferenceException can also be thrown from SemaphoreSlim.
@AArnott AArnott mentioned this issue Apr 27, 2017
Merged
@AArnott AArnott modified the milestone: v1.1 May 3, 2017
@AArnott AArnott removed this from the v1.1 milestone Jul 10, 2017
@AArnott
Copy link
Member Author

AArnott commented Oct 12, 2017

This is due to Roslyn using objects after they've been disposed, and Roslyn has fixed this in their code. I don't think we need to make StreamJsonRpc more resilient than a threading primitive when these types are being misused.

@AArnott AArnott closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AArnott