-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyzer proposal: pass CancellationToken explicitly #591
Labels
Comments
See also #394 and consider how they will relate. |
+1 on this one. See this recent regression bug in LSP client due to failure to propagate CancellationTokens: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1083283 It has actually been fixed on at least 2 occasions before. |
This was implemented in roslyn-analyzers in dotnet/roslyn-analyzers#3641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This analyzer would report cases where a method is called with an implicit cancellation token:
Each of the three cases [should|should not] have the same diagnostic ID:
CancellationToken
parameterCancellationToken
CancellationToken
(as an optional parameter or a different overload)The text was updated successfully, but these errors were encountered: