Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asar breaks finding keytar #36

Closed
chrisdias opened this issue Jan 30, 2018 · 2 comments
Closed

asar breaks finding keytar #36

chrisdias opened this issue Jan 30, 2018 · 2 comments
Assignees
@chrmarti

Comments

@chrisdias
Copy link
Member

the change in VS Code to move to ASAR changes where to find keytar, line 27 of azure-account.ts:

keytar = require(`${env.appRoot}/node_modules/keytar`)

should be

keytar = require(`${env.appRoot}/node_modules.asar/keytar`)
@chrisdias chrisdias added this to the January 2018 milestone Jan 30, 2018
@chrmarti chrmarti modified the milestones: January 2018, February 2018 Feb 1, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Feb 1, 2018

1.20 will ship with ASAR turned off.

@chrmarti
Copy link
Contributor

Fixed in #39

@chrmarti chrmarti removed this from the February 2018 milestone Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrmarti chrmarti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisdias @chrmarti