Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node 12 #1713

Closed
ColbyTresness opened this issue Nov 23, 2019 · 6 comments · Fixed by #1803
Closed

Add support for Node 12 #1713

ColbyTresness opened this issue Nov 23, 2019 · 6 comments · Fixed by #1803
Milestone

Comments

@ColbyTresness
Copy link

The functions service will soon allow hosting Node 12 applications, and we should add support in the tooling for:

  • version selection on creation (similar to what we do for Python)
  • validation on publishing (local version matches Azure version)
  • Once platform is ready, default should be Node 12 and Functions V3
@ColbyTresness
Copy link
Author

Also note that when a user upgrades to V3 we should ensure that their node versions are compatible with that runtime version

@johnpapa
Copy link

I was just about to open an issue for this. I received

[error] Incompatible Node.js version. The version you are using is v12.13.1, but the runtime requires an LTS-covered major version (ex: 8.11.1 or 10.14.1). LTS-covered versions have an even major version number (8.x, 10.x, etc.) as per https://github.com/nodejs/Release#release-plan. For deployed code, change WEBSITE_NODE_DEFAULT_VERSION in App Settings. Locally, install or switch to a supported node version (make sure to quit and restart your code editor to pick up the changes).

Seems the tools need to be updated for Node 12 as an LTS. RIght?

cc @fiveisprime

@ColbyTresness
Copy link
Author

Yeah in the interim while we don't support Node 12, we should update this string

@johnpapa
Copy link

Thanks for the reply @ColbyTresness

This may cause some friction when we start publishing the 25 days of Serverless in December, @simonaco (just as an FYI).

Anyone trying with Node 12 who tries these may run into it. If it won't be supported by Dec 1, then we may want to add instructions to each challenge to mention using Node 10.

@ejizba
Copy link
Contributor

ejizba commented Dec 2, 2019

@ColbyTresness we already support multiple versions of Node (8 and 10). It sounds like all we need to do is add 12 to that list, right? Your original comment includes some stuff that I believe is already done.

In regards to the message @johnpapa mentioned, that error is coming from the func cli, not our extension. I believe updates to that message are being tracked here: Azure/azure-functions-nodejs-worker#200

@ColbyTresness
Copy link
Author

Basically, yes, but I'd wait a bit until the platform is completely ready. Forwarding you an email where I explain the entire situation.

@ejizba ejizba added the feature label Jan 15, 2020
@ejizba ejizba added this to the 0.20.2 milestone Jan 15, 2020
@ejizba ejizba added the v3 label Jan 15, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants