Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Insights APM 2.1 Enablement and Representation #2835

Closed
apawast opened this issue Jun 2, 2021 · 2 comments · Fixed by #3254
Closed

App Insights APM 2.1 Enablement and Representation #2835

apawast opened this issue Jun 2, 2021 · 2 comments · Fixed by #3254

Comments

@apawast
Copy link

apawast commented Jun 2, 2021

Problem

App Insights has introduced APM 2.1 which integrates log analytics and application insights logs into a workspace so a user can view all their logs in one place. Currently, when VSCode creates an application insights resource during a function creation, a 2.1 workspace is used by default. Portal has created a new experience to be able to change/create a workspace within the Function create blade. The logic behind when a user is allowed to create a new workspace is complicated in Portal. The ask is for VSCode to be on par with Portal’s capabilities around APM 2.1.

Background

This is how Portal works today:

Screen Shot 2021-05-27 at 9 07 22 PM

When you go to the monitoring tab of Function creation blade, Portal always automatically autofills with a new application insights resource. The user can also choose to select an existing resource from the drop down. If the user wants to, they can go forward with no more configuration.

The third option is to click “create new” and see the default options AI created and change them.

Screen Shot 2021-05-27 at 9 07 39 PM

However, Portal uses complicated logic to determine when to allow the user to create a default workspace or an existing workspace.

This is how it works in VSCode today:

In VSCode if the user chooses simple function app creation, then an app insights resource is created by default when published. If the user chooses advanced function app creation, then they get the choice to use an existing AI resource or create a new one.

Screen Shot 2021-05-27 at 9 08 26 PM

If the user chooses to create a new one, similarly to Portal, VSCode autofills a name for the resource in the same region. There is no choice for further configuration.

Screen Shot 2021-05-27 at 9 50 08 PM

Requirements

  • VSCode is on par for APM 2.1 support with Portal. The logic can be found in the Antares UX OneNote
  • Add a new step to the Functions creation process to allow users to choose a location
  • Add a new step to the Functions creation process to allow users to create/choose a workspace. Follow the diagram in this OneNote for the logic of when this extra step should even be an option for users. This extra step should only be necessary when using “advanced” creation flow.
  • Validate that both the basic and advanced flows are using workspace based by default when creating default AI resources.
@ejizba ejizba added the feature label Jun 7, 2021
@ejizba ejizba added this to the Backlog Candidates milestone Jun 7, 2021
@ejizba ejizba added the P2 label Jun 7, 2021
@ejizba ejizba modified the milestones: Backlog Candidates, 1.5.0 Jun 7, 2021
@fiveisprime
Copy link
Member

Basic create:

  • Create a new 2.1 instance with a new workspace in the same resource group as the app

Advanced create:

  • Prompt to create or select existing AI instance
  • If creating new and a workspace exists in the resource group, prompt to choose a new workspace or select existing
  • If no workspaces exist in the resource group, create a new workspace (still open question on whether this is done automatically when creating a new AI instance)

Open questions

  • What does the SDK/RP handle for us?
  • Does creating a new 2.1 instance automatically create a workspace?

@ejizba ejizba modified the milestones: 1.5.0, 1.6.0 Jul 12, 2021
@ejizba ejizba modified the milestones: 1.5.0, 1.6.0 Aug 24, 2021
@nturinski nturinski modified the milestones: 1.6.0, 1.7.0 Nov 5, 2021
@Phuurl
Copy link

Phuurl commented Apr 18, 2022

Worth noting as well that currently when deploying a new Function and creating the associated new app insights resource via the VSCode extension, upon visiting that resource in the Portal users are warned that the resource is deprecated as well as a few features being unavailable until it is migrated to the new type:

eg 1 (on the main overview panel):
image

eg 2:
image

(I believe this is the same issue, shout if it isn't and I'll open a new issue for it 👍)

@alexweininger alexweininger modified the milestones: 1.7.0, 1.8.0 Jun 9, 2022
@microsoft microsoft locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants