Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run npm install after initializing TypeScript project #3034

Closed
anthonychu opened this issue Jan 18, 2022 · 3 comments · Fixed by #3362
Closed

Automatically run npm install after initializing TypeScript project #3034

anthonychu opened this issue Jan 18, 2022 · 3 comments · Fixed by #3362
Assignees
Milestone

Comments

@anthonychu
Copy link
Member

Is it possible to run npm i after initializing a TS project (maybe do it for JS too for consistency)?

@wwlorey
Copy link
Contributor

wwlorey commented Jan 20, 2022

As of right now we do this for the user on debug. What is the reason you'd like to see npm i run for this case?

@fiveisprime what are your thoughts on this?

@wwlorey wwlorey added the info-needed See https://aka.ms/azcodeissuereporting label Jan 20, 2022
@ejizba
Copy link
Contributor

ejizba commented Jan 20, 2022

We already do something similar for Python (pip install), so js/ts could be modeled after that. A few reasons I like this:

  1. Users will get a 'clean' project as opposed to immediately seeing build errors from missing dependencies
  2. Users might want to do some coding (with intellisense) before they debug, hence why they need npm i earlier

Only downside might be a delay while npm i runs, but with the right order of operations I think it could be tastefully done. Besides, they'll have to run npm i eventually no matter what.

@ejizba ejizba removed the info-needed See https://aka.ms/azcodeissuereporting label Jan 20, 2022
@fiveisprime
Copy link
Member

I love the idea of running it immediately after creating the project. It always bugs me that I have errors in the index.ts that opens from not having run npm install.

@nturinski nturinski added this to the 1.7.0 milestone Jan 27, 2022
@alexweininger alexweininger modified the milestones: 1.7.0, 1.8.0 Jun 9, 2022
@nturinski nturinski modified the milestones: 1.8.0, 1.9.0 Sep 21, 2022
@MicroFish91 MicroFish91 self-assigned this Sep 28, 2022
@microsoft microsoft locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants