Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded CMAKE_EXPORT_COMPILE_COMMANDS getting in the way #1440

Closed
treilly-nuodb opened this issue Sep 17, 2020 · 1 comment
Closed

Hardcoded CMAKE_EXPORT_COMPILE_COMMANDS getting in the way #1440

treilly-nuodb opened this issue Sep 17, 2020 · 1 comment
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: configure
Milestone

Comments

@treilly-nuodb
Copy link

Brief Issue Summary

I had to hack the this extension to turn off CMAKE_EXPORT_COMPILE_COMMANDS. It needs to be turned off when doing unity builds.

Expected:

There should be a way to override the default behavior of hardcoding CMAKE_EXPORT_COMPILE_COMMANDS to true. Our typical workflow is to run cmake once with it on and then turn it off and run again with unity on.

@andreeis andreeis modified the milestones: On Deck, Backlog Oct 19, 2020
@andreeis andreeis added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: configure labels Oct 19, 2020
@andreeis
Copy link
Contributor

We almost have CMake Tools 1.6.0 release out the door. Until then, if you want, you can also verify if this problem has been fixed correctly by installing the vsix built here: https://github.com/microsoft/vscode-cmake-tools/actions/runs/557242002#artifacts.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: configure
Projects
None yet
Development

No branches or pull requests

3 participants