Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes of default CWD folder break targets run. #1460

Closed
grapland0 opened this issue Sep 28, 2020 · 3 comments
Closed

Changes of default CWD folder break targets run. #1460

grapland0 opened this issue Sep 28, 2020 · 3 comments
Labels
documentation related to documentation of the extension Feature: debug/launch
Milestone

Comments

@grapland0
Copy link

grapland0 commented Sep 28, 2020

The change is introduced from #1395. Could we consider to revert this change?

This change silently breaks the feature behind launch/debug status bar shortcut, if the target uses some data with relative path to the work folder (e.g. data of unit tests). And it is not easy to find the root cause and fix without digging into that issue thread.

@bobbrow
Copy link
Member

bobbrow commented Oct 12, 2020

We can understand that it may be unclear at times how to override the defaults for our quick debug action and we're sorry that this caused you trouble. We won't be reverting this change as we feel that ${workspaceFolder} is less likely to be the correct location, but it is overridable by using the cmake.debugConfig setting.

We should update the documentation here to explicitly mention the cmake.debugConfig setting.

@bobbrow bobbrow added documentation related to documentation of the extension Feature: debug/launch labels Oct 12, 2020
@bobbrow bobbrow added this to the Backlog milestone Oct 19, 2020
@xgdgsc
Copy link
Contributor

xgdgsc commented Dec 23, 2020

This change feels stupid to me. How many people needs loading plugins from build folders? How many people needs loading config from workspaceFolder?

@grapland0
Copy link
Author

let me close this to reduce backlog. I have fixed my launch settings, but still think this feature should be reconsidered.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation related to documentation of the extension Feature: debug/launch
Projects
None yet
Development

No branches or pull requests

3 participants