-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakePresets: "warnings" field settings are not passed on to CMake #2009
Comments
Thank you for reporting this issue. Looks like a simple logic mistake in the code. @xisui-MSFT could you fix this real quick? vscode-cmake-tools/src/preset.ts Line 1247 in 192fec8
Yes, this is likely possible, but Kitware has requested that IDE's/editors do their own parsing instead of using |
Also Thanks for this explanation. I have been wondering what the rationale was to reconstruct rather using the |
I'm not sure which doc would be an appropriate place for it. People would ask anyway. 😅 We committed a fix for this. If you want to try it out, you can download the VSIX here: https://github.com/microsoft/vscode-cmake-tools/suites/3342925255/artifacts/78474075 |
When creating the command line to invoke CMake the
warnings
field is ignored and it is impossible to pass warning command line arguments to CMake. For example in this case--no-warn-unused-cli
shall be passed on to CMake.Example:
As a side note, this issue would not occur if this plugin would use the
--preset
argument to invoke CMake rather than building its own command line.The text was updated successfully, but these errors were encountered: