Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kit scan generates incorrect kits for VS 2022 #2054

Closed
Colengms opened this issue Aug 13, 2021 · 0 comments · Fixed by #2055
Closed

Kit scan generates incorrect kits for VS 2022 #2054

Colengms opened this issue Aug 13, 2021 · 0 comments · Fixed by #2055
Assignees
Labels
bug a bug in the product Feature: kits

Comments

@Colengms
Copy link
Contributor

I repro'ed this with 1.7.3 and an internal build of 1.8.0. It looks like the VS 2022 kits are missing some required fields.

When I scan for kits, this is what I get for 2019:

  {
    "name": "Visual Studio Enterprise 2019 Preview - amd64",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x64",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "x64",
      "toolset": "host=x64"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - amd64_arm",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x64",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "arm",
      "toolset": "host=x64"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - amd64_arm64",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x64",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "arm64",
      "toolset": "host=x64"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - amd64_x86",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x64",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "win32",
      "toolset": "host=x64"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - x86",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x86",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "win32",
      "toolset": "host=x86"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - x86_amd64",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x86",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "x64",
      "toolset": "host=x86"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - x86_arm",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x86",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "arm",
      "toolset": "host=x86"
    }
  },
  {
    "name": "Visual Studio Enterprise 2019 Preview - x86_arm64",
    "visualStudio": "9b5c4e3f",
    "visualStudioArchitecture": "x86",
    "preferredGenerator": {
      "name": "Visual Studio 16 2019",
      "platform": "arm64",
      "toolset": "host=x86"
    }
  },

This is what I get for 2022:

  {
    "name": "Visual Studio Enterprise 2022 Preview - amd64",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x64"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - amd64_arm",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x64"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - amd64_arm64",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x64"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - amd64_x86",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x64"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - x86",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x86"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - x86_amd64",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x86"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - x86_arm",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x86"
  },
  {
    "name": "Visual Studio Enterprise 2022 Preview - x86_arm64",
    "visualStudio": "39cd74d5",
    "visualStudioArchitecture": "x86"
  },

As a result, the only 2022 kits that work properly are the x86 and amd64 kits. The amd64_x86, x86_amd64, arm and arm64 kits, etc., don't work as expected.

@elahehrashedi elahehrashedi added bug a bug in the product Feature: kits labels Aug 13, 2021
@elahehrashedi elahehrashedi self-assigned this Aug 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug a bug in the product Feature: kits
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants