Extra {0} output message when having preset with circular inherits

[linquize]

Extra {0} output message when having preset with circular inherits.

Expected:

Output panel

[preset] circular.inherits.in.config.preset Circular inherits in configure preset my-preset

Apparent Behavior:

Output panel

[preset] circular.inherits.in.config.preset Circular inherits in configure preset {0} my-preset

Platform and Versions

• Operating System: Windows
• CMake Version: 3.12.18081601
• VSCode Version: 1.60
• CMake Tools Extension Version: 1.8.1
• Compiler/Toolchain: Visual C++ 2017

[linquize]

vscode-cmake-tools/src/preset.ts

Line 368 in 874cc84

log.error('circular.inherits.in.config.preset', 'Circular inherits in configure preset {0}', preset.name);

vscode-cmake-tools/src/preset.ts

Line 586 in 874cc84

log.error('circular.inherits.in.config.preset', 'Circular inherits in configure preset {0}', preset.name);

vscode-cmake-tools/src/preset.ts

Line 799 in 874cc84

log.error('circular.inherits.in.build.preset', 'Circular inherits in build preset {0}', preset.name);

vscode-cmake-tools/src/preset.ts

Line 807 in 874cc84

log.error('circular.inherits.in.test.preset', 'Circular inherits in test preset {0}', preset.name);

vscode-cmake-tools/src/preset.ts

Line 956 in 874cc84

log.error('circular.inherits.in.build.preset', 'Circular inherits in build preset {0}', preset.name);

vscode-cmake-tools/src/preset.ts

Line 1169 in 874cc84

log.error('circular.inherits.in.test.preset', 'Circular inherits in test preset {0}', preset.name);

[bobbrow]

Good catch. @xisui-MSFT it looks like log.error is being called as if it were the localize API. Can you fix this?

[andreeis]

This fix is included in the 1.9.0 CMake Tools release. Please upgrade your extension in VSCode and let us know if you encounter any other issues.