Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation for cmake-variants.yaml doesn't work #2135

Closed
TSlivede opened this issue Sep 21, 2021 · 2 comments · Fixed by #3720
Closed

Schema validation for cmake-variants.yaml doesn't work #2135

TSlivede opened this issue Sep 21, 2021 · 2 comments · Fixed by #3720
Labels
Milestone

Comments

@TSlivede
Copy link

TSlivede commented Sep 21, 2021

Brief Issue Summary

https://vector-of-bool.github.io/docs/vscode-cmake-tools/variants.html says:

Note: CMake Tools provides a YAML validation schema, which is only checked in the editor when using the YAML Support by Red Hat extension.

I installed YAML Language Support but get the error:

Cannot Load content for: cmake-tools-schema:///schemas/variants-schema.json. Unknown schema: 'cmake-tools-schema'

Expected:

  1. Create file cmake-variants.yaml in project root directory
  2. open file
  3. get schema based auto completion

Apparent Behavior:

  1. Create file cmake-variants.yaml in project root directory
  2. open file
  3. click on variants-schema.json shown directly above line 1
  4. get error listed above.

CMake Tools Log

[variant] Loaded new set of variants
[kit] Successfully loaded 8 kits from /home/user/.local/share/CMakeTools/cmake-tools-kits.json

Other Logs

The output window for "YAML Support" is completely empty.

Platform and Versions

  • Operating System: Ubuntu 20.04.3 LTS
  • CMake Version: 3.16
  • VSCode Version: 1.16.1
  • CMake Tools Extension Version: 1.8.1
  • Compiler/Toolchain: GCC 9.3
  • Red Hat YAML Language Support: 0.22.0

Other Notes/Information

~/.vscode/extensions/ms-vscode.cmake-tools-1.8.1/dist/schema contains schemas in several languages

A created cmake-variants.json file gets successfully validated against the schema.

@andreeis andreeis added this to the 1.10.0 milestone Sep 29, 2021
@andreeis
Copy link
Contributor

@TSlivede, thank you for opening this report. We reproduce the problem. We will investigate and fix this.

@gcampbell-msft
Copy link
Collaborator

gcampbell-msft commented Apr 24, 2024

@TSlivede This should get resolved by #3720, once merged, please confirm, thanks!

@gcampbell-msft gcampbell-msft linked a pull request Apr 24, 2024 that will close this issue
@gcampbell-msft gcampbell-msft modified the milestones: On Deck, 1.18 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants