cmake.preferredGenerators no longer honored in MSVC #4095
Comments
|
I'm currently using |
|
I did some code inspection, this is caused by #3869, specifically this line https://github.com/microsoft/vscode-cmake-tools/blob/main/src/drivers/cmakeDriver.ts#L733: It shouldn't I'm aware of |
jonnysoe
changed the title
|
@gcampbell-msft I can repro this issue with following environment, the output window displays Environment: Repro Steps:
|
v-frankwang
added
more info needed
|
@jonnysoe Thank you for posting this issue. This is expected behavior currently, as the kit preferred generator is preferred over cmake.preferredGenerator currently, and as you pointed out, we currently don't detect whether the MSVC generator is present, we only check if you're on Windows and if so, assume that it is present. Your workaround is currently the suggested use case / workaround, and we'll take your feedback into consideration. Again, we appreciate the issue and feedback! |
gcampbell-msft
added
bug
Brief Issue Summary
I don't know which CMake tools version onwards was broken but I recently updated to 1.19.52, Windows will always run cmake configuration with MSVC,
-G "Visual Studio 17 2022"regardless of user specified preferred generator.I specified Ninja in
.vscode\settings.jsonor%APPDATA%\Code\User\settings.json:P.S. This is a Windows bug, it still works on Linux.
CMake Tools Diagnostics
{ "os": "win32", "vscodeVersion": "1.90.2", "cmtVersion": "1.19.52", "configurations": [ { "folder": "c:\\_\\comfork", "cmakeVersion": "3.25.1", "configured": true, "generator": "Visual Studio 17 2022", "usesPresets": false, "compilers": {} } ], "cpptoolsIntegration": { "isReady": true, "hasCodeModel": true, "activeBuildType": "Debug", "buildTypesSeen": [ "Debug", "Release", "MinSizeRel", "RelWithDebInfo" ], "requests": [], "responses": [], "partialMatches": [], "targetCount": 7, "executablesCount": 4, "librariesCount": 1, "targets": [ { "name": "ALL_BUILD", "type": "UTILITY" }, { "name": "ZERO_CHECK", "type": "UTILITY" }, { "name": "libcomfork", "type": "STATIC_LIBRARY" }, { "name": "main_c", "type": "EXECUTABLE" }, { "name": "main_cpp", "type": "EXECUTABLE" }, { "name": "main_nowait_c", "type": "EXECUTABLE" }, { "name": "main_nowait_cpp", "type": "EXECUTABLE" } ] }, "settings": [ { "communicationMode": "automatic", "useCMakePresets": "auto", "configureOnOpen": false } ] }Debug Log
Additional Information
Here is a screenshot of mismatching launch.json and cmake generator:
Here is a screenshot that shows I have ninja installed:
The text was updated successfully, but these errors were encountered: