Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hover setting requires window reload and does not trigger reload window prompt #10076

Closed
Colengms opened this issue Oct 28, 2022 · 0 comments
Assignees
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@Colengms
Copy link
Collaborator

The new setting to enable/disable hover is passed in the ServerCapabilities object in response to LSP initialization. So, if the setting was disabled when the window was loaded, enabling it would require the window to be reloaded to properly initialize LSP to send hover requests.

The autocomplete setting is similar. Though, changes to the autocomplete setting do trigger a reload window prompt.

VS Code will merge the results from multiple hover providers, and does something similar (? based on score) with completion. So, I don't believe it's necessary to avoid registering as a hover or completion provider. We could avoid requiring the user to reload the window when either of these settings are changed, by always registering as a provider for them.

@Colengms Colengms added this to the On Deck milestone Oct 28, 2022
@browntarik browntarik self-assigned this Oct 28, 2022
@browntarik browntarik modified the milestones: On Deck, 1.14 Oct 28, 2022
@bobbrow bobbrow modified the milestones: 1.14, On Deck Feb 9, 2023
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.14.2 Feb 9, 2023
@browntarik browntarik added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

No branches or pull requests

4 participants