You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sean-mcmanus #10072 Makes it impossible to use older versions (< 12) of clang-format, which don't have `--Wno-error=unknown` yet.
The default version of the clang-format package in Ubuntu <= 20.04 cannot handle this option. Additionally, older versions of clang-format are still widely in use in my experience due to how formatting changes often between different versions.
I would therefore argue that the change from #10072 should not be published without an accompanying solution to this issue.
This should enable clang-format 11 or older (regressed from 1.13.4) and clang-format 8 or older (which would fail with the default
"Visual Studio" style with 1.12.4 and earlier versions)...I think we still have a minimum requirement of like clang 4 or so though, but those versions seem too old to worry about.
sean-mcmanus
added
the
fixed
Check the Milestone for the release in which the fix is or will be available.
label
Nov 29, 2022
The default version of the
clang-format
package in Ubuntu <= 20.04 cannot handle this option. Additionally, older versions of clang-format are still widely in use in my experience due to how formatting changes often between different versions.I would therefore argue that the change from #10072 should not be published without an accompanying solution to this issue.
Originally posted by @saierd in #10102 (comment)
The text was updated successfully, but these errors were encountered: