Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure's type definition syntax highlight absence #1051

Closed
lefedehd opened this issue Sep 21, 2017 · 4 comments
Closed

structure's type definition syntax highlight absence #1051

lefedehd opened this issue Sep 21, 2017 · 4 comments
Labels
duplicate external more info needed The issue report is not actionable in its current state

Comments

@lefedehd
Copy link

Environments:
Windows 7 sp1
VS Code 1.16.1
ms-vscode.cpptools, solely

issues:
/*code sample
/****************DMA CONTROL Register define *************************/
typedef struct _DMA_CHANNEL_REG
{
volatile unsigned int DMACC0SADDR;
volatile unsigned int DMACC0DADDR;
volatile unsigned int DMACC0LLI;
volatile unsigned int DMACC0CTRL;
volatile unsigned int DMACC0CONFIG;
}DMA_CHANNEL_REG;
*/

Just like the preceeding code I pasted, DMA_CHANNEL_REG is NOT highlighted!
But, when I hover over it, I can see its definition.

@sean-mcmanus
Copy link
Collaborator

I don't see any unexpected behavior. typedef int DMA_CHANNEL_REG gives the same colorization. What are you expecting? Also, our extension doesn't implement any C/C++ colorization -- it comes from atom/language-c, so any bug fixes would need to be filed/fixed there: https://github.com/atom/language-c/issues .

@sean-mcmanus sean-mcmanus added external more info needed The issue report is not actionable in its current state labels Sep 21, 2017
@lefedehd
Copy link
Author

Oh, I got it. I thought that C language typedefed structure highlight was related to ms-vscode.cpptools regarding the definiton pop-up when I hover over it. I am sorry for the mistake. Thanks for your replay. I will move my question to https://github.com/atom/language-c/issues .

@lefedehd lefedehd reopened this Sep 21, 2017
@lefedehd
Copy link
Author

Find another reference but no solutions.
atom/language-c#243

@sean-mcmanus
Copy link
Collaborator

We're responsible for the hover, but not any of the colorization. We're tracking this via #230 .

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate external more info needed The issue report is not actionable in its current state
Projects
None yet
Development

No branches or pull requests

2 participants