Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Status follow up for compilerPath #10527

Closed
bobbrow opened this issue Feb 14, 2023 · 5 comments
Closed

Language Status follow up for compilerPath #10527

bobbrow opened this issue Feb 14, 2023 · 5 comments
Assignees
Labels
enhancement Improvement to an existing feature Feature: Status Language Service

Comments

@bobbrow
Copy link
Member

bobbrow commented Feb 14, 2023

When no compiler is configured, the link for IntelliSense Status in the Language Status flyout should run the "select a compiler" command. Alex's suggested text for the link is "Improve IntelliSense."

@sean-mcmanus
Copy link
Collaborator

I would prefer something like "Configure IntelliSense" over "Improve IntelliSense". Was there a reason to use "improve" instead?

@bobbrow
Copy link
Member Author

bobbrow commented Feb 15, 2023

IntelliSense is already "configured" albeit incorrectly. This makes the configuration better.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Feb 15, 2023

I don't understand. If no compiler is configured then we've selected one on own. To "configure" implies "an explicit action to configure something correctly". The verb "improve" seems too generic and seems to imply that the link will enable IntelliSense to be better, faster, more accurate, etc., when it's really just "configuring" to work correctly with a particular compiler.

For example, the command "CMake: Configure" would be strange to rename "CMake: Improve". Unless I'm misunderstanding something.

@bobbrow
Copy link
Member Author

bobbrow commented Feb 15, 2023

If no compiler is configured then we've selected one on own.

I believe this is for the case where we would have shown the prompt to confirm our compiler selection. If they dismiss that, we don't have a compiler at all. We configure without it. I'm not particular about the text here. Please sync with @AlexandraKemperMS and come to a consensus if you would like to have different text.

@bobbrow
Copy link
Member Author

bobbrow commented Mar 15, 2023

This issue has been replaced by #10685

@bobbrow bobbrow closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature Feature: Status Language Service
Projects
None yet
Development

No branches or pull requests

4 participants