Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In windows, "console": "integratedTerminal" option works better? #11032

Closed
caiohamamura opened this issue May 31, 2023 · 2 comments
Closed

In windows, "console": "integratedTerminal" option works better? #11032

caiohamamura opened this issue May 31, 2023 · 2 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. tasks/build/debug An issue relating to tasks.json (e.g. build issues)
Milestone

Comments

@caiohamamura
Copy link
Contributor

caiohamamura commented May 31, 2023

In this line, the externalTerminal is hardcoded. But for Windows cl.exe as suggested by the VSCode documentation, at least, this won't work. We have to manually change everytime to integratedTerminal to work, or else the Debugger won't attach.

newConfig.console = "externalTerminal";

Can anyone else confirm this, or am I missing something?

If that is true shouldn't the extension check if the user is running cl.exe and use integratedTerminal instead by default?

@michelleangela michelleangela added tasks/build/debug An issue relating to tasks.json (e.g. build issues) bug labels Jun 10, 2023
@michelleangela michelleangela added this to the 1.16.1 milestone Jun 15, 2023
@michelleangela michelleangela added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 19, 2023
@michelleangela
Copy link
Contributor

@michelleangela
Copy link
Contributor

Fix is now available in release version 1.16.2.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. tasks/build/debug An issue relating to tasks.json (e.g. build issues)
Projects
None yet
Development

No branches or pull requests

2 participants