Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Hierarchy child items aren't formatted correctly (default arguments are shown) #11247

Closed
sean-mcmanus opened this issue Jul 26, 2023 · 2 comments
Labels
bug Feature: Call Hierarchy fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jul 26, 2023

See the screenshot. The root definition is formatted correctly but the children are not, which makes the arguments harder to read.

image

Repro code is like

#include <unordered_map>

int foo() { return 0; }

bool func(std::unordered_map<int, int> * d = nullptr)
{
    return foo() == 1;
}

The bug should be easy to fix by doing the formatting that is done for the root definition on the child items.

@michelleangela
Copy link
Contributor

Before fix:
image

After fix:
image

@michelleangela michelleangela removed their assignment Aug 1, 2023
@michelleangela michelleangela added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 1, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.17, 1.17.1 Aug 8, 2023
@michelleangela
Copy link
Contributor

@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Call Hierarchy fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Development

No branches or pull requests

2 participants