Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move "Updating C/C++ dependencies" output to foreground #1160

Closed
Tyriar opened this issue Oct 23, 2017 · 4 comments
Closed

Don't move "Updating C/C++ dependencies" output to foreground #1160

Tyriar opened this issue Oct 23, 2017 · 4 comments
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2017

It feels like almost every time I open VS Code Insiders with the extension installed, this output is forced to the foreground. This annoyance, plus the fact I don't use C++ often, forces me to uninstall the extension and only keep it installed when using.

The output could easily be kept in the background and only moved to the foreground when an error is detected.

image

@sean-mcmanus
Copy link
Contributor

What about the reload pop up that appears? I would think that would be more annoying than the output window. I'm thinking maybe we should only download dependencies and require a reload when someone first uses a C/C++ project (i.e. keep our stricter activation events as default).

@Tyriar
Copy link
Member Author

Tyriar commented Oct 28, 2017

@sean-mcmanus that's annoying too, I'm kind of used to it at this point and that sort of thing will eventually be improved via an improved notifications system in VS Code. Any improvements to that are certainly welcome.

Hijacking the panel is a much bigger annoyance for me, I don't mind if the extension grabs new deps in the background silently though.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Oct 30, 2017

Sounds good. We've made these changes for our next update:

  1. We no longer force showing the C/C++ output channel unless the install fails.
  2. We won't try to download the dependencies until our activation events are hit (C/C++ file opened, c_cpp_properties.json exists in the workspace, C/Cpp command used, etc.).
  3. We no longer require an additional reload window. Instead, the reload prompt only appears if launch.json is opened and it explains that the reload is only required if you want the debugger configuration snippets.

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Oct 30, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Oct 30, 2017

Perfect 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

3 participants