-D__FILENAME__=\\\"filename.c\\\" in compile_commands.json is not parsed properly

[schultetwin1]

We use cmake to generate a __FILENAME__ definition for each file that is passed into the command line. __FILENAME__ is the same as __FILE__ without the full path. In compile_commands.json this will show up in the command as -D__FILENAME__=\\\"filename.c\\\". The first backslash escapes the second backslash and the third backslash escapes the ". This is so that on the command line it will show up as -D__FILENAME__=\"filename.c\" so that the quotes are escaped for the command.

In vscode, the intellisense thinks __FILENAME__ is \"filename.c\" instead of "filename.c". This causes a red squiggle under the __FILENAME__ macro.

A quick repro of this issue is to add the following to a CMakeLists.txt

set(FILENAME filename.c)
target_compile_definitions(target PUBLIC __FILENAME__="${FILENAME}") 

[huww98]

I have the same problem with my ros project.

compile_commands.json contains something like -DROS_PACKAGE_NAME=\\\"my_package_name\\\" and VSCode show errors on every rosconsole calls (like ROS_FATAL("some message.");). If I change it to -DROS_PACKAGE_NAME=\"my_package_name\", then everything works.

[bobbrow]

Thanks for reporting this.

[sean-mcmanus]

I hit this myself last week (from the repro project in #1777 ), but I didn't realize it was a bug.

[bobbrow]

I'm testing a fix for this right now.

[schultetwin1]

Awesome, thank you!

[bobbrow]

A preview of this is available in the insiders build if you would like to try it out and provide feedback.

[schultetwin1]

Just tried the preview. It worked great, thank you!

[bobbrow]

This is fixed in 0.17.0.