Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing a didChange event with many edits (such as from document formatting) is too slow #7159

Closed
sean-mcmanus opened this issue Mar 11, 2021 · 0 comments
Closed

Processing a didChange event with many edits (such as from document formatting) is too slow #7159

sean-mcmanus opened this issue Mar 11, 2021 · 0 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance quick fix
Milestone
1.3.0

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Mar 11, 2021 •
edited
Loading

Doing a format document can cause 500+ edits to be processed from didChange and every one may have to iterate over every character of the document, which can take 7+ seconds for a 2-3k line file, which seems too slow.

This was hit when investigating #7131 .
@sean-mcmanus sean-mcmanus self-assigned this Mar 11, 2021
@bobbrow bobbrow added this to the 1.3.0 milestone Mar 11, 2021
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. quick fix labels Mar 11, 2021
@sean-mcmanus sean-mcmanus mentioned this issue Mar 11, 2021
Closed
@sean-mcmanus sean-mcmanus removed their assignment Mar 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance quick fix
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@bobbrow @sean-mcmanus