Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto add parentheses incorrectly occurs with template methods #7203

Closed
KnewHow opened this issue Mar 21, 2021 · 3 comments
Closed

Auto add parentheses incorrectly occurs with template methods #7203

KnewHow opened this issue Mar 21, 2021 · 3 comments
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service quick fix regression A bug that didn't exist in a previous release
Milestone
1.3.0

Comments

@KnewHow
Copy link

KnewHow commented Mar 21, 2021 •
edited
Loading

Type: LanguageService

Describe the bug

  • OS and Version: Ubuntu 20.04
  • VS Code Version: 1.54.3
    2b9aebd5354a3629c3aba0a5f5df49f43d6689f8
    x64
  • C/C++ Extension Version: 1.3.0-insider
  • Other extensions you installed (and if the issue persists after disabling them): Cmake
  • Does this issue involve using SSH remote to run the extension on a remote machine?: No
  • I know you add some parenthesis after some value function, for example std::optional<Person> s; s.value(), the parenthesis is auto complete is prefect here, but when I input std::share_ptr, it will auto add () after it, it see very terrible! I just want a code like std::share_ptr<> to add some type, but you give me a parenthesis. I hope you can do better, thank you!
@KnewHow
Copy link
Author

KnewHow commented Mar 21, 2021

the vesion is: 1.3.0-insiders!

@sean-mcmanus sean-mcmanus changed the title Add extra parenthesis sometimes it is very terrible Auto add parentheses incorrectly occurs with template methods Mar 22, 2021
@sean-mcmanus sean-mcmanus self-assigned this Mar 22, 2021
@sean-mcmanus sean-mcmanus added bug Feature: Auto-complete insiders Currently only repros with our latest Insiders release. Language Service regression A bug that didn't exist in a previous release labels Mar 22, 2021
@sean-mcmanus sean-mcmanus added this to the 1.3.0 milestone Mar 22, 2021
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. quick fix labels Mar 22, 2021
@sean-mcmanus
Copy link
Collaborator

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/1.3.0-insiders2

@sean-mcmanus sean-mcmanus removed their assignment Apr 5, 2021
@michelleangela
Copy link
Contributor

Fix is released in the 1.3.0 release version https://github.com/microsoft/vscode-cpptools/releases/tag/1.3.0

@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. insiders Currently only repros with our latest Insiders release. Language Service quick fix regression A bug that didn't exist in a previous release
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@sean-mcmanus @KnewHow @michelleangela