Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code folding will collapse entire line containing closing bracket in some scenarios #7792

Closed
Colengms opened this issue Jul 7, 2021 · 0 comments · Fixed by #7793
Closed
Assignees
Labels
bug Feature: Code Folding fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@Colengms
Copy link
Collaborator

Colengms commented Jul 7, 2021

This is based on #5521 , which appears to have partially addressed the issue.

Folding a block before an else (on the same line as closing bracket) will still collapse the line containing the else, in the following scenario:

    if (true) {
      if (false) {
        ;
      }
      ;
    } else {
      ;
    }

Ideally, folding should always avoid folding the else into the first block when on the same line as the closing bracket for the first block.

@Colengms Colengms added this to the Backlog milestone Jul 7, 2021
@sean-mcmanus sean-mcmanus self-assigned this Jul 7, 2021
@sean-mcmanus sean-mcmanus modified the milestones: Backlog, 1.5.0 Jul 7, 2021
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jul 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Code Folding fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants