Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy "notes" applying to excluded files can appear for non-excluded files (and possibly causing incorrect warning filtering) #8723

Closed
sean-mcmanus opened this issue Jan 26, 2022 · 0 comments
Assignees
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

If a clang-tidy warning occurs that is followed by another warning that is excluded that has "notes", the notes can get associated with the non-excluded warning instead of the excluded warning, causing the "note" to appear attached to the wrong warning.

This can also cause warnings to be incorrectly filtered out if the "notes" is an "expanded from macro" or "Calling" type.

@sean-mcmanus sean-mcmanus added bug Language Service fixed Check the Milestone for the release in which the fix is or will be available. Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. labels Jan 26, 2022
@sean-mcmanus sean-mcmanus added this to the 1.8.1 milestone Jan 26, 2022
@sean-mcmanus sean-mcmanus self-assigned this Jan 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

1 participant