Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy "errors" should not have exclusions applied (and other exclusion-related bugs) #8724

Closed
sean-mcmanus opened this issue Jan 26, 2022 · 0 comments
Assignees
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service

Comments

@sean-mcmanus
Copy link
Collaborator

Use

#include <vector>

int main()
{
    std::vector<int> vi{};
    vi.emplace_back(std::pair<int, int>{});
}

We filter out the clang error (assuming system headers warnings are filtered out)...ideally we'd show it in this case, i.e. when there is a "note" referencing a non-excluded file.

@sean-mcmanus sean-mcmanus added bug Language Service Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. labels Jan 26, 2022
@sean-mcmanus sean-mcmanus added this to the 1.9.0 milestone Jan 26, 2022
@sean-mcmanus sean-mcmanus self-assigned this Jan 26, 2022
@sean-mcmanus sean-mcmanus changed the title No clang-tidy error/warning is reported for std::vector problems (when system headers are excluded but it has a "note" to a non-excluded file) clang-tidy "errors" should not have exclusions applied Jan 27, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.9.0, 1.8.1 Jan 27, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.8.1, 1.9.0 Jan 27, 2022
@sean-mcmanus sean-mcmanus changed the title clang-tidy "errors" should not have exclusions applied clang-tidy "errors" should not have exclusions applied (and other exclusion-related bugs) Jan 27, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 3, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.9, 1.9.0 (insiders) Feb 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Code Analysis Related to integration with clang-tidy, cppcheck, cl.exe /analyze, etc. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

1 participant