Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always show SSH Targets View #9836

Closed
xisui-MSFT opened this issue Sep 1, 2022 · 1 comment
Closed

Don't always show SSH Targets View #9836

xisui-MSFT opened this issue Sep 1, 2022 · 1 comment
Assignees
Labels
fixed Check the Milestone for the release in which the fix is or will be available.
Milestone

Comments

@xisui-MSFT
Copy link
Collaborator

Feature Request

#9760 Always shows an SSH Targets View in the debug panel, which may be annoying for users who are not using this feature.

It's hard to determine if users use or don't use it. We can probably show it when a related command is invoked, but not being able to see a list of devices before invoking commands seems pretty awkward and confusing...

Andrew suggests that we can check 'host' in launch.json. It's a good idea, with the only drawback being it requires listening to configuration change event, which fires on all settings changes.

Also open to other suggestions.

@xisui-MSFT xisui-MSFT self-assigned this Sep 1, 2022
@sean-mcmanus sean-mcmanus added this to the 1.13.1 milestone Sep 16, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 16, 2022
@sean-mcmanus
Copy link
Collaborator

@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Check the Milestone for the release in which the fix is or will be available.
Projects
None yet
Development

No branches or pull requests

2 participants