Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to clear timeout in DebugClient.waitForEvent #209

Open
simark opened this issue Jan 17, 2019 · 0 comments
Open

Need to clear timeout in DebugClient.waitForEvent #209

simark opened this issue Jan 17, 2019 · 0 comments
Labels
feature-request Request for new features or functionality
Milestone

Comments

@simark
Copy link

simark commented Jan 17, 2019

I am using DebugClient in some unit tests, and noticed that my test runner (mocha) took some time to exit after the tests completed successfully. I traced it to this timer in DebugClient.waitForEvent. It is never cancelled, so the node process waits for it to expire before exiting.

https://github.com/Microsoft/vscode-debugadapter-node/blob/64665fe18a0316b2a871df4b36cff214c28d2598/testSupport/src/debugClient.ts#L292-L299

Ideally, it would be cancelled when the event is received and the promise is resolved. I can't sign the CLA required to contribute to this repository, so I can't contribute a patch, but the changes required are very simple.

@weinand weinand self-assigned this Jan 28, 2019
@weinand weinand added this to the February 2019 milestone Jan 28, 2019
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Jan 28, 2019
@weinand weinand added the feature-request Request for new features or functionality label Oct 19, 2021
@weinand weinand removed the bug Issue identified by VS Code Team member as probable bug label Oct 19, 2021
@weinand weinand removed their assignment Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants