Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile against debug adapter without node typings #272

Open
dbaeumer opened this issue Sep 13, 2022 · 2 comments
Open

Can't compile against debug adapter without node typings #272

dbaeumer opened this issue Sep 13, 2022 · 2 comments
Assignees
Labels

Comments

@dbaeumer
Copy link
Member

I wanted to implement a debug adapter for the web using the @vscode/debugadapter npm module but I can't compile the code with out having node typings install (which gives a wrong impression for people want to do something for the web). The reason for that are these reference /// <reference types="node" /> in the provided d.ts files.

Would it be possible to have a module that I can use without node typings. If you want I can explain how I did this for LSP.

@connor4312
Copy link
Member

It looks like we currently depend on NodeJS types for (exclusively?) readable/writable streams. We could probably swap those out for minimal interfaces within the module which NodeJS streams can be duck-typed into. If we were to make a breaking change I would suggest taking Readable/Writable streams from the Streams API, which is standard with Node.js APIs that allow conversion to and fro.

@dbaeumer
Copy link
Member Author

@weinand weinand removed their assignment Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants