Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Protocol: support 'restart frame' #43

Closed
weinand opened this issue Jul 12, 2016 · 3 comments
Closed

Debug Protocol: support 'restart frame' #43

weinand opened this issue Jul 12, 2016 · 3 comments
Assignees
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 12, 2016

Add protocol support for a restartFrame request.
A single argument frameId specifies the frame to restart.

@weinand weinand added this to the July 2016 milestone Jul 12, 2016
@weinand weinand self-assigned this Jul 12, 2016
@DavidKarlas
Copy link
Member

DavidKarlas commented Jul 12, 2016

This is similar to #28?
Maybe it could be merged into one command with addition of optional frame index parameter?
It might be confusing having two very similar commands unless I misunderstand this command...

@weinand
Copy link
Contributor Author

weinand commented Jul 12, 2016

@DavidKarlas good idea, I will consider your suggestion.
For now I have already added the restartFrame to the protocol, but the 1.11 version of the protocol is only a preview until the end of the sprint.

@weinand
Copy link
Contributor Author

weinand commented Jul 14, 2016

@DavidKarlas I've tried to merge 'restartFrame' into the 'setNextStatement' proposed in #28 but in the end I gave up because supporting different kinds of parameters (frameId vs. source location) on 'setNextStatement' was just adding complexity without gaining much: the UI for 'setNextStatement' is quite different from 'restartFrame'. The former works on individual statements in the source, the latter is more useful on call stack frames. So typically there is no shared code that has to deal with both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants