Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit fec1e78

Browse files
paddymorgan84paddymorgan84
authored
Spelling correction: Minkube -> Minikube (#1534)
1 parent 80a9660 commit fec1e78

File tree

7 files changed

+102
-140
lines changed

7 files changed

+102
-140
lines changed

‎containers/codespaces-linux/.devcontainer/library-scripts/kubectl-helm-debian.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ find_version_from_git_tags() {
7575
local repository=$2
7676
local prefix=${3:-"tags/v"}
7777
local separator=${4:-"."}
78-
local last_part_optional=${5:-"false"}
78+
local last_part_optional=${5:-"false"}
7979
if [ "$(echo "${requested_version}" | grep -o "." | wc -l)" != "2" ]; then
8080
local escaped_separator=${separator//./\\.}
8181
local last_part
@@ -225,8 +225,8 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
225225
MINIKUBE_VERSION="v${MINIKUBE_VERSION}"
226226
fi
227227
fi
228-
# latest is also valid in the download URLs
229-
curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"
228+
# latest is also valid in the download URLs
229+
curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"
230230
chmod 0755 /usr/local/bin/minikube
231231
if [ "$MINIKUBE_SHA256" = "automatic" ]; then
232232
MINIKUBE_SHA256="$(curl -sSL "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}.sha256")"
@@ -236,7 +236,7 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
236236
echo '(!) minikube installation failed!'
237237
exit 1
238238
fi
239-
# Create minkube folder with correct privs in case a volume is mounted here
239+
# Create minikube folder with correct privs in case a volume is mounted here
240240
mkdir -p "${USERHOME}/.minikube"
241241
chown -R $USERNAME "${USERHOME}/.minikube"
242242
chmod -R u+wrx "${USERHOME}/.minikube"
@@ -246,4 +246,4 @@ if ! type docker > /dev/null 2>&1; then
246246
echo -e '\n(*) Warning: The docker command was not found.\n\nYou can use one of the following scripts to install it:\n\nhttps://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/docker-in-docker.md\n\nor\n\nhttps://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/docker.md'
247247
fi
248248

249-
echo -e "\nDone!"
249+
echo -e "\nDone!"

‎containers/kubernetes-helm-minikube/.devcontainer/library-scripts/kubectl-helm-debian.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ find_version_from_git_tags() {
7575
local repository=$2
7676
local prefix=${3:-"tags/v"}
7777
local separator=${4:-"."}
78-
local last_part_optional=${5:-"false"}
78+
local last_part_optional=${5:-"false"}
7979
if [ "$(echo "${requested_version}" | grep -o "." | wc -l)" != "2" ]; then
8080
local escaped_separator=${separator//./\\.}
8181
local last_part
@@ -225,8 +225,8 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
225225
MINIKUBE_VERSION="v${MINIKUBE_VERSION}"
226226
fi
227227
fi
228-
# latest is also valid in the download URLs
229-
curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"
228+
# latest is also valid in the download URLs
229+
curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"
230230
chmod 0755 /usr/local/bin/minikube
231231
if [ "$MINIKUBE_SHA256" = "automatic" ]; then
232232
MINIKUBE_SHA256="$(curl -sSL "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}.sha256")"
@@ -236,7 +236,7 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
236236
echo '(!) minikube installation failed!'
237237
exit 1
238238
fi
239-
# Create minkube folder with correct privs in case a volume is mounted here
239+
# Create minikube folder with correct privs in case a volume is mounted here
240240
mkdir -p "${USERHOME}/.minikube"
241241
chown -R $USERNAME "${USERHOME}/.minikube"
242242
chmod -R u+wrx "${USERHOME}/.minikube"
@@ -246,4 +246,4 @@ if ! type docker > /dev/null 2>&1; then
246246
echo -e '\n(*) Warning: The docker command was not found.\n\nYou can use one of the following scripts to install it:\n\nhttps://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/docker-in-docker.md\n\nor\n\nhttps://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/docker.md'
247247
fi
248248

249-
echo -e "\nDone!"
249+
echo -e "\nDone!"

‎containers/kubernetes-helm/.devcontainer/library-scripts/kubectl-helm-debian.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ find_version_from_git_tags() {
7575
local repository=$2
7676
local prefix=${3:-"tags/v"}
7777
local separator=${4:-"."}
78-
local last_part_optional=${5:-"false"}
78+
local last_part_optional=${5:-"false"}
7979
if [ "$(echo "${requested_version}" | grep -o "." | wc -l)" != "2" ]; then
8080
local escaped_separator=${separator//./\\.}
8181
local last_part
@@ -225,8 +225,8 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
225225
MINIKUBE_VERSION="v${MINIKUBE_VERSION}"
226226
fi
227227
fi
228-
# latest is also valid in the download URLs
229-
curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"
228+
# latest is also valid in the download URLs
229+
curl -sSL -o /usr/local/bin/minikube "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}"
230230
chmod 0755 /usr/local/bin/minikube
231231
if [ "$MINIKUBE_SHA256" = "automatic" ]; then
232232
MINIKUBE_SHA256="$(curl -sSL "https://storage.googleapis.com/minikube/releases/${MINIKUBE_VERSION}/minikube-linux-${architecture}.sha256")"
@@ -236,7 +236,7 @@ if [ "${MINIKUBE_VERSION}" != "none" ]; then
236236
echo '(!) minikube installation failed!'
237237
exit 1
238238
fi
239-
# Create minkube folder with correct privs in case a volume is mounted here
239+
# Create minikube folder with correct privs in case a volume is mounted here
240240
mkdir -p "${USERHOME}/.minikube"
241241
chown -R $USERNAME "${USERHOME}/.minikube"
242242
chmod -R u+wrx "${USERHOME}/.minikube"
@@ -246,4 +246,4 @@ if ! type docker > /dev/null 2>&1; then
246246
echo -e '\n(*) Warning: The docker command was not found.\n\nYou can use one of the following scripts to install it:\n\nhttps://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/docker-in-docker.md\n\nor\n\nhttps://github.com/microsoft/vscode-dev-containers/blob/main/script-library/docs/docker.md'
247247
fi
248248

249-
echo -e "\nDone!"
249+
echo -e "\nDone!"

‎containers/kubernetes-helm/README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
*Access a local (or remote) Kubernetes cluster from inside a dev container using your local config. Includes kubectl, Helm, and the Docker CLI.*
66

7-
| Metadata | Value |
7+
| Metadata | Value |
88
|----------|-------|
99
| *Contributors* | The VS Code team and Phetsinorath William |
1010
| *Categories* | Other |
@@ -80,9 +80,9 @@ However, this section will outline the how you can selectively add this function
8080

8181
That's it!
8282

83-
## A note on Minkube or otherwise using a local cluster
83+
## A note on Minikube or otherwise using a local cluster
8484

85-
While this definition works with Minkube in most cases, if you hit trouble, make sure that your `~/.kube/config` file and Minikube certs reference your host's IP rather than `127.0.0.1` or `localhost` (since `localhost` resolve to the container itself rather than your local machine where Minikube is running).
85+
While this definition works with Minikube in most cases, if you hit trouble, make sure that your `~/.kube/config` file and Minikube certs reference your host's IP rather than `127.0.0.1` or `localhost` (since `localhost` resolve to the container itself rather than your local machine where Minikube is running).
8686

8787
This should happen by default on Linux. On macOS and Windows, we recommend using the Kuberntes install that comes with Docker Desktop instead of Minikube to avoid these kinds of issues.
8888

@@ -167,4 +167,4 @@ While you cannot sync or connect to your local Kubernetes configuration with Cod
167167

168168
Copyright (c) Microsoft Corporation. All rights reserved.
169169

170-
Licensed under the MIT License. See [LICENSE](https://github.com/microsoft/vscode-dev-containers/blob/main/LICENSE).
170+
Licensed under the MIT License. See [LICENSE](https://github.com/microsoft/vscode-dev-containers/blob/main/LICENSE).

0 commit comments

Comments
 (0)