Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'filter' of null during BuildImage #2072

Closed
samirpatry opened this issue Jun 17, 2020 · 9 comments · Fixed by #2111
Closed

Cannot read property 'filter' of null during BuildImage #2072

samirpatry opened this issue Jun 17, 2020 · 9 comments · Fixed by #2111
Milestone

Comments

@samirpatry
Copy link

Cannot read property 'filter' of null during BuildImage

image

@bwateratmsft
Copy link
Collaborator

This looks similar to #2030. @samirpatry, do you have any custom values for any of the docker.commands.* settings?

@samirpatry
Copy link
Author

This looks similar to #2030. @samirpatry, do you have any custom values for any of the docker.commands.* settings?

NO. Anywhere i can check this.

Note: Very new to VSCode.

@bwateratmsft
Copy link
Collaborator

No problem! Let's check your settings.

  1. Open the command palette (F1 by default)
  2. Type in "open settings", look for the command "Preferences: Open Settings (JSON)"
  3. This will open a small or even empty JSON file containing all of your user-customized settings. In here, look for anything called "docker.commands.*".

@samirpatry
Copy link
Author

Yes its there.
"docker.commands.build": null,
Whats should i set here ?

{
"[go]": {
"editor.formatOnSave": false
},
"go.formatTool": "goimports",
"vs-kubernetes": {
"vs-kubernetes.kubectl-path.windows": "C:\Users\samir.patry\.vs-kubernetes\tools\kubectl\kubectl.exe",
"vs-kubernetes.minikube-path.windows": "C:\Users\samir.patry\.vs-kubernetes\tools\minikube\windows-amd64\minikube.exe",
"vs-kubernetes.helm-path.windows": "C:\Users\samir.patry\.vs-kubernetes\tools\helm\windows-amd64\helm.exe",
"vs-kubernetes.draft-path.windows": "C:\Users\samir.patry\.vs-kubernetes\tools\draft\windows-amd64\draft.exe",
"vs-kubernetes.knownKubeconfigs": [
"c:\Users\samir.patry\Desktop\temp\config"
],
"vs-kubernetes.kubeconfig": "c:\Users\samir.patry\Desktop\temp\config"
},
"[dockerfile]": {

},
"docker.commands.build": null,
"vsdocker.imageUser": "rajviva",
"docker.volumes.sortBy": "Label"

}

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Jun 17, 2020

You should remove docker.commands.build entirely, the default setting will work for you for now.

@samirpatry
Copy link
Author

Yes working fine now.

@bwateratmsft
Copy link
Collaborator

Glad it's working now! Please let us know if any other issues come up!

@samirpatry
Copy link
Author

Thanks @bwateratmsft . We can close this.

@bwateratmsft
Copy link
Collaborator

We have released Docker 1.4.0 which contains a fix for this.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants