Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add commands "Compose Logs" in command palette #2770

Closed
v-ruizh opened this issue Mar 11, 2021 · 5 comments · Fixed by #2804
Closed

[Suggestion] Add commands "Compose Logs" in command palette #2770

v-ruizh opened this issue Mar 11, 2021 · 5 comments · Fixed by #2804

Comments

@v-ruizh
Copy link

v-ruizh commented Mar 11, 2021

OS: Ubuntu 18.04
Build Version: 20210310.1

Repro Steps:

  1. Right click docker-compose.yml file and execute "Compose Up" action.
  2. Navigate to Docker view -> Right click the container group and check its menu.
    image
  3. F1 to check whether these commands are in command palette or not.

Actual:
These commands don't exist in command palette.

Suggestion:
Add commands "Compose Logs/Compose Restart/ Compose Down" in command palette.

@v-ruizh v-ruizh added the AT-CTI label Mar 11, 2021
@bwateratmsft
Copy link
Collaborator

Restart and Down are available in the palette, albeit with slightly different names ("Docker: Compose Restart" and "Docker: Compose Down"). Logs is not, we should consider adding that.

@bwateratmsft bwateratmsft changed the title [Suggestion] Add commands "Compose Logs/Compose Restart/ Compose Down" in command palette [Suggestion] Add command "Compose Logs" in command palette Mar 12, 2021
@v-ruizh
Copy link
Author

v-ruizh commented Mar 15, 2021

@bwateratmsft The commands "Docker: Compose Restart" and "Docker: Compose Down" in the command palette you mentioned above is for docker-compose.yml or docker-compose.debug.yml, but the one I mentioned is for Container group.

When I try to executing "Docker: Compose Restart" and "Docker: Compose Down" commands, it require one project folder opening which contains docker-compose.yml file, we can select the docker-compose.yml file to continue this action.

But I can right click container group and executing "Compose Restart/ Compose Down" without any folder opening.

I guess they may be difference. Could you help to confirm this?

@bwateratmsft
Copy link
Collaborator

Ah yes, you are totally right. Fixing the title.

@bwateratmsft bwateratmsft changed the title [Suggestion] Add command "Compose Logs" in command palette [Suggestion] Add commands "Compose Logs/Compose Restart/ Compose Down" in command palette Mar 15, 2021
@bwateratmsft bwateratmsft changed the title [Suggestion] Add commands "Compose Logs/Compose Restart/ Compose Down" in command palette [Suggestion] Add commands "Compose Logs" in command palette Mar 23, 2021
@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Mar 23, 2021

Unfortunately there is no good way to handle the user experience of showing the "Down" and "Restart" commands in the palette, since there are already such commands but targeted to files instead of running compose projects. Users would see two of the same command and we couldn't really explain how they were different.

Logs is a new command, so it is possible to work it this way. Updated the title.

@bwateratmsft
Copy link
Collaborator

This fix is now released with Docker extension version 1.12.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants