Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output in the OUTPUT window is missing characters #3616

Closed
charris-msft opened this issue Sep 16, 2022 · 4 comments · Fixed by #3858
Closed

Output in the OUTPUT window is missing characters #3616

charris-msft opened this issue Sep 16, 2022 · 4 comments · Fixed by #3858

Comments

@charris-msft
Copy link

charris-msft commented Sep 16, 2022

Issue

I've run through the "Build Image in Azure..." process a number of times and I've been surprised by the number of missing characters I see in the output window.

Here are some examples:
image

Expected behavior

I expect to see 100% of the characters that are being logged displayed in the OUTPUT window.

Video Repros

https://microsoft.sharepoint.com/:f:/t/JEM/EklDiahGaQtDigc5E2SlrYAB3YU7H2NvdoiyIo1AkQUZ-A?e=eCGRIh

@bwateratmsft
Copy link
Collaborator

These logs are being streamed from Azure. Need to investigate whether the missing data is happening on service-side (in which case we can't do anything about it) or if it's happening on the client.

Related to #3617

@dbreshears
Copy link
Member

We should figure out if it is coming from the service or if we are causing

@bwateratmsft bwateratmsft self-assigned this Mar 8, 2023
@bwateratmsft
Copy link
Collaborator

I looked into it, and what's happening is that we're downloading a complete block blob--starting from some byte offset--and outputting it to the output window. I couldn't get it to reproduce, but I'm fairly confident that what was happening here--and in #3617--was the byteOffset was slipping due to non-printing terminal control characters not being counted. Slipping backward would cause things to be printed again (as in #3617), slipping forward would cause things to be skipped (as in here).

Additionally, due to #3809, we were outputting redundant timestamps--one from VSCode's log output window, one from the actual blob logs. This was ugly, but we can't prevent VSCode from emitting its timestamps. The simplest solution was to remove the redundant timestamps from the logs themselves.

I have a fix for both the byte offset slippage and the timestamp formatting.

@alexyaang
Copy link
Member

This has now been released in Docker extension version 1.25.0.

@microsoft microsoft locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants