Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile schema missing support for HEALTHCHECK --start-interval switch #4054

Closed
lonix1 opened this issue Sep 2, 2023 · 2 comments · Fixed by #4065
Closed

Dockerfile schema missing support for HEALTHCHECK --start-interval switch #4054

lonix1 opened this issue Sep 2, 2023 · 2 comments · Fixed by #4065
Labels
fix released language-server
Milestone
1.27.0

Comments

@lonix1
Copy link

lonix1 commented Sep 2, 2023

The HEALTHCHECK allows a --start-interval switch, which is unrecognised:

Unknown flag: start-interval dockerfile-utils

vscode 1.80.2
extension 1.26.0
docker 24.0.5
@bwateratmsft
Copy link
Collaborator

@rcjsuen can you look at this? Thanks!

@bwateratmsft bwateratmsft added this to the 1.28.0 milestone Sep 6, 2023
@rcjsuen
Copy link
Contributor

rcjsuen commented Sep 8, 2023

Interestingly enough, this feature is actually not live yet (docker/cli#4486). However, it can be enabled with #syntax=docker/dockerfile:1 and I have confirmed that to be the case.

I have opened rcjsuen/dockerfile-utils#115 to track this. Thank you for reporting this issue, @lonix1.

@rcjsuen rcjsuen mentioned this issue Sep 10, 2023
Merged
@bwateratmsft bwateratmsft linked a pull request Sep 11, 2023 that will close this issue
Update Dockerfile language server to 0.11.0 #4065
Merged
@alexyaang alexyaang modified the milestones: 1.28.0, 1.27.0 Sep 19, 2023
@microsoft microsoft locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
fix released language-server
Projects
None yet
Milestone
1.27.0
Development

Successfully merging a pull request may close this issue.

Update Dockerfile language server to 0.11.0 rcjsuen/vscode-docker
4 participants
@rcjsuen @bwateratmsft @lonix1 @alexyaang